add Column.len, which returns Scalar, instead of Column.__len__ (returning int) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
column-len
branch
from
fa4fb66
to
eb1daa6
Compare
|
@shwina what is your thoughts on this one? I know cuDF is eager and so it always has the length of columns accessible, but given its scalar class is built to be on device (ignoring the internal implementation of how it handles both host and device access), do you have any thoughts here? |
|
So I expect the length to be used for things like comparisons or equality checking which does work between Scalars and plain Python integers in cuDF. This should be an OK change |
|
approved in today's call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.