Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce false reporting of isBlocked packages in integrity checks. #8341

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Reduce false reporting of isBlocked packages in integrity checks. #8341

merged 1 commit into from
Nov 28, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Nov 27, 2024

@sigurdm
Copy link
Contributor

sigurdm commented Nov 28, 2024

Is this reducing or eliminating the reporting?

@isoos
Copy link
Collaborator Author

isoos commented Nov 28, 2024

Is this reducing or eliminating the reporting?

I'm not confident enough to claim that it will eliminate all of the reports we have seen this week, but it has a high chance that it will catch all of the issues being reported as false positives.

@isoos isoos merged commit 7e107a5 into dart-lang:master Nov 28, 2024
32 checks passed
@isoos isoos deleted the fix-integrity branch November 28, 2024 08:27
isoos added a commit that referenced this pull request Nov 29, 2024
@isoos
Reduce false reporting of isBlocked packages in integrity checks. (#8341
d40f2ae 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm