Reduce false reporting of isBlocked packages in integrity checks. (#8341

)
dart-lang · Nov 29, 2024 · d40f2ae · d40f2ae
1 parent 806b8de
commit d40f2ae
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/app/lib/shared/integrity.dart b/app/lib/shared/integrity.dart
@@ -424,7 +424,7 @@ class IntegrityChecker {
       isModerated: p.isModerated,
       moderatedAt: p.moderatedAt,
     );
-    if (p.isModerated) {
+    if (p.isModerated || p.isBlocked) {
       _packagesWithIsModeratedFlag.add(p.name!);
     }
 

diff --git a/app/test/frontend/handlers/custom_api_test.dart b/app/test/frontend/handlers/custom_api_test.dart
@@ -161,6 +161,10 @@ void main() {
           'nextUrl': null,
         },
       );
+
+      // reverting to make sure integrity check is passing
+      p.updateIsBlocked(isBlocked: false);
+      await dbService.commit(inserts: [p]);
     });
   });
 

diff --git a/app/test/frontend/handlers/documentation_test.dart b/app/test/frontend/handlers/documentation_test.dart
@@ -149,6 +149,9 @@ void main() {
       await dbService.commit(inserts: [pkg!..updateIsBlocked(isBlocked: true)]);
       await expectNotFoundResponse(
           await issueGet('/documentation/oxygen/latest/'));
+
+      // reverting to make sure integrity check is passing
+      await dbService.commit(inserts: [pkg..updateIsBlocked(isBlocked: false)]);
     });
   });
 }
diff --git a/app/test/frontend/handlers/package_test.dart b/app/test/frontend/handlers/package_test.dart
@@ -54,6 +54,9 @@ void main() {
           await issueGet('/packages/oxygen/versions/${pkg.latestVersion}'));
       await expectNotFoundResponse(await issueGet(
           '/packages/oxygen/versions/${pkg.latestVersion}/score'));
+
+      // reverting to make sure integrity check is passing
+      await dbService.commit(inserts: [pkg..updateIsBlocked(isBlocked: false)]);
     });
 
     testWithProfile('/packages/foobar_not_found - not found', fn: () async {