Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DarcyWebMatchers with HasClass matcher #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/com/redhat/darcy/web/matchers/DarcyWebMatchers.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.redhat.darcy.web.matchers;

import com.redhat.darcy.ui.matchers.DarcyMatchers;
import com.redhat.darcy.web.api.elements.HtmlElement;

import org.hamcrest.Matcher;

public abstract class DarcyWebMatchers extends DarcyMatchers {
public static <T extends HtmlElement> Matcher<T> hasClass(Matcher<? super String> matcher) {
return new HasClass<>(matcher);
}
}
35 changes: 35 additions & 0 deletions src/main/java/com/redhat/darcy/web/matchers/HasClass.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package com.redhat.darcy.web.matchers;

import com.redhat.darcy.web.api.elements.HtmlElement;

import org.hamcrest.Description;
import org.hamcrest.Matcher;
import org.hamcrest.TypeSafeDiagnosingMatcher;

public class HasClass<T extends HtmlElement> extends TypeSafeDiagnosingMatcher<T> {
private Matcher<? super String> matcher;

public HasClass(Matcher<? super String> matcher) {
this.matcher = matcher;
}

@Override
public void describeTo(Description description) {
description.appendText("an element that has the class ");
matcher.describeTo(description);
}

@Override
protected boolean matchesSafely(T t, Description description) {
for (String clazz : t.getClasses()) {
if (matcher.matches(clazz)) {
return true;
}
}

description.appendText("could not find a matching class in ")
.appendValue(t.getClasses());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two improvements you can make with this and then we're good:

  1. Append the element to String and the getClasses -- again if we just use getClasses, then this is no better than using the already provided collection matchers
  2. Also use the matcher provided to describe what about a class you were looking for


return false;
}
}
56 changes: 56 additions & 0 deletions src/test/java/com/redhat/darcy/web/matchers/HasClassTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package com.redhat.darcy.web.matchers;

import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import com.redhat.darcy.web.api.elements.HtmlElement;

import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;

import java.util.ArrayList;
import java.util.List;

@RunWith(JUnit4.class)
public class HasClassTest {
@Test
public void shouldMatchFullClass() {
HasClass<HtmlElement> matcher = new HasClass<>(equalTo("clazz"));
HtmlElement mockElement = mock(HtmlElement.class);

List<String> classes = new ArrayList<>();
classes.add("clazz");
when(mockElement.getClasses()).thenReturn(classes);

assertTrue(matcher.matches(mockElement));
}

@Test
public void shouldMatchPartialClass() {
HasClass<HtmlElement> matcher = new HasClass<>(containsString("cla"));
HtmlElement mockElement = mock(HtmlElement.class);

List<String> classes = new ArrayList<>();
classes.add("clazz");
when(mockElement.getClasses()).thenReturn(classes);

assertTrue(matcher.matches(mockElement));
}

@Test
public void shouldNotMatchMissingClass() {
HasClass<HtmlElement> matcher = new HasClass<>(containsString("missing"));
HtmlElement mockElement = mock(HtmlElement.class);

List<String> classes = new ArrayList<>();
classes.add("clazz");
when(mockElement.getClasses()).thenReturn(classes);

assertFalse(matcher.matches(mockElement));
}
}