-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DarcyWebMatchers with HasClass matcher #46
Open
dmcneil
wants to merge
3
commits into
darcy-framework:master
Choose a base branch
from
dmcneil:web-matchers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
src/main/java/com/redhat/darcy/web/matchers/DarcyWebMatchers.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.redhat.darcy.web.matchers; | ||
|
||
import com.redhat.darcy.ui.matchers.DarcyMatchers; | ||
import com.redhat.darcy.web.api.elements.HtmlElement; | ||
|
||
import org.hamcrest.Matcher; | ||
|
||
public abstract class DarcyWebMatchers extends DarcyMatchers { | ||
public static <T extends HtmlElement> Matcher<T> hasClass(Matcher<? super String> matcher) { | ||
return new HasClass<>(matcher); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package com.redhat.darcy.web.matchers; | ||
|
||
import com.redhat.darcy.web.api.elements.HtmlElement; | ||
|
||
import org.hamcrest.Description; | ||
import org.hamcrest.Matcher; | ||
import org.hamcrest.TypeSafeDiagnosingMatcher; | ||
|
||
public class HasClass<T extends HtmlElement> extends TypeSafeDiagnosingMatcher<T> { | ||
private Matcher<? super String> matcher; | ||
|
||
public HasClass(Matcher<? super String> matcher) { | ||
this.matcher = matcher; | ||
} | ||
|
||
@Override | ||
public void describeTo(Description description) { | ||
description.appendText("an element that has the class "); | ||
matcher.describeTo(description); | ||
} | ||
|
||
@Override | ||
protected boolean matchesSafely(T t, Description description) { | ||
for (String clazz : t.getClasses()) { | ||
if (matcher.matches(clazz)) { | ||
return true; | ||
} | ||
} | ||
|
||
description.appendText("could not find a matching class in ") | ||
.appendValue(t.getClasses()); | ||
|
||
return false; | ||
} | ||
} |
56 changes: 56 additions & 0 deletions
56
src/test/java/com/redhat/darcy/web/matchers/HasClassTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
package com.redhat.darcy.web.matchers; | ||
|
||
import static org.hamcrest.Matchers.containsString; | ||
import static org.hamcrest.Matchers.equalTo; | ||
import static org.junit.Assert.assertFalse; | ||
import static org.junit.Assert.assertTrue; | ||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.when; | ||
|
||
import com.redhat.darcy.web.api.elements.HtmlElement; | ||
|
||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.junit.runners.JUnit4; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
@RunWith(JUnit4.class) | ||
public class HasClassTest { | ||
@Test | ||
public void shouldMatchFullClass() { | ||
HasClass<HtmlElement> matcher = new HasClass<>(equalTo("clazz")); | ||
HtmlElement mockElement = mock(HtmlElement.class); | ||
|
||
List<String> classes = new ArrayList<>(); | ||
classes.add("clazz"); | ||
when(mockElement.getClasses()).thenReturn(classes); | ||
|
||
assertTrue(matcher.matches(mockElement)); | ||
} | ||
|
||
@Test | ||
public void shouldMatchPartialClass() { | ||
HasClass<HtmlElement> matcher = new HasClass<>(containsString("cla")); | ||
HtmlElement mockElement = mock(HtmlElement.class); | ||
|
||
List<String> classes = new ArrayList<>(); | ||
classes.add("clazz"); | ||
when(mockElement.getClasses()).thenReturn(classes); | ||
|
||
assertTrue(matcher.matches(mockElement)); | ||
} | ||
|
||
@Test | ||
public void shouldNotMatchMissingClass() { | ||
HasClass<HtmlElement> matcher = new HasClass<>(containsString("missing")); | ||
HtmlElement mockElement = mock(HtmlElement.class); | ||
|
||
List<String> classes = new ArrayList<>(); | ||
classes.add("clazz"); | ||
when(mockElement.getClasses()).thenReturn(classes); | ||
|
||
assertFalse(matcher.matches(mockElement)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two improvements you can make with this and then we're good: