Add DarcyWebMatchers with HasClass matcher

[dmcneil]

No description provided.

[dmcneil]

Thinking a bit more about this while at lunch, I wonder if it would be better to accept a Matcher<? super String> instead of just a String so you could perhaps do something like element, hasClass(containsString("cla")) on an element that had a class of clazz...

[dmcneil]

I decided that using the Matcher<? super String> allows for some more freedom/versatility.

[alechenninger]

Probably worthwhile to extend darcy-ui's DarcyMatchers. This makes it easier to consume all matchers, and prevents name collisions (which is important because I imagine these will be ripe for static imports).

[dmcneil]

For clarification, are you saying either use TypeSafeDiagnosingMatcher on the matcher I have here as is or rewrite it to work off a Collection instead of an HtmlElement and then just pass in the List<String> you get from element.getClasses() in the assertion rather than using getClasses() in the matcher itself?

[alechenninger]

The former: use the diagnosing matcher in the matcher you are writing.

The alternative is to not write another matcher at all, and just use the collections matchers already available against the Set from getClasses(). But, this has the downside of not being able to explain the context about the set: all it knows is that it was a set of strings. If you do this matcher and make it self-diagnosing, we can get more context about the failure, which is nice.

[dmcneil]

Oh yeah that makes complete sense, duh, the matchers already exist for collections. Uhh, yeah...brain still waking up for Monday. I'll get this fixed. Thanks for the quick response.

[alechenninger]

Two improvements you can make with this and then we're good:

1. Append the element to String and the getClasses -- again if we just use getClasses, then this is no better than using the already provided collection matchers
2. Also use the matcher provided to describe what about a class you were looking for

[alechenninger]

Hey @dmcneil :-). Any interest in working on those last two improvements?