Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foot: disable faulty check #576

Merged
merged 2 commits into from
Nov 8, 2024
Merged

foot: disable faulty check #576

merged 2 commits into from
Nov 8, 2024

Conversation

Mikilio
Copy link
Contributor

@Mikilio Mikilio commented Sep 26, 2024

This solves #571. But since this is only a temporary fix, it does not need to be merged. See SenchoPens/base16.nix#15

There may be a way to do this better, but at least it works for me.

@trueNAHO
Copy link
Collaborator

This solves #571. But since this is only a temporary fix, it does not need to be merged. See SenchoPens/base16.nix#15

Unless we need to update this input or users override this input with follows, the mentioned issue should not cause any problems.

There may be a way to do this better, but at least it works for me.

It might be easier and better to wait some time for a potential upstream fix. If this becomes a bigger problem and upstream takes too long to fix this, we could apply this temporary hotfix.

@trueNAHO trueNAHO changed the title fix(foot): disable faulty check foot: disable faulty check Sep 27, 2024
@Mikilio
Copy link
Contributor Author

Mikilio commented Sep 27, 2024

I agree.

@anotherhadi
Copy link

The issue is still there, how to use your pull request as the flake input?

@psynyde
Copy link

psynyde commented Oct 9, 2024

The issue is still there, how to use your pull request as the flake input?

You need to change the input to the repo where the pr is coming from (ie github:Mikilio/stylix/temp-fix-foot in this case).
Note that the repo is behind some commits compared to master branch here

@Mikilio
Copy link
Contributor Author

Mikilio commented Nov 4, 2024

Apparently this is still an issue.

@Mikilio Mikilio force-pushed the temp-fix-foot branch 4 times, most recently from 67e0b4f to c0099d7 Compare November 4, 2024 02:21
@Mikilio
Copy link
Contributor Author

Mikilio commented Nov 4, 2024

So I've changed the fix to simply pinning the tinted-theming/foot repo. Maybe this can actually be merged?
If you agree, I will make it ready.

tags Outdated Show resolved Hide resolved
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the copy-paste mistake, this PR LGTM:

Reviewed-by: NAHO <[email protected]>

flake.nix Outdated Show resolved Hide resolved
Co-authored-by: NAHO <[email protected]>
@Mikilio Mikilio requested a review from trueNAHO November 8, 2024 09:42
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :))

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: NAHO <[email protected]>

@trueNAHO trueNAHO merged commit 6863412 into danth:master Nov 8, 2024
2 checks passed
@trueNAHO
Copy link
Collaborator

trueNAHO commented Nov 8, 2024

The CI of 6863412 is failing for some reason...

@Mikilio
Copy link
Contributor Author

Mikilio commented Nov 9, 2024

unpacking 'github:tinted-theming/tinted-foot/fd1b924b6c45c3e4465e8a849e67ea82933fcbe4' into the Git cache...
error:
       … while updating the lock file of flake 'github:danth/stylix/655528278fd89fd7f3149f47fdca994b08dd0b71?narHash=sha256-Jg7peqzVbv4ULKNyx9wVIevsLbycDWfSfGpqheX06dc%3D'

       error: cannot write modified lock file of flake 'github:danth/stylix/655528278fd89fd7f3149f47fdca994b08dd0b71' (use '--no-write-lock-file' to ignore)

Well, I did not update the lockfile. That much is true.
So maybe it should be updated for the CI?
A simple nix flake lock --update-input tinted-foot should suffice (did not check for typos).

trueNAHO added a commit to trueNAHO/stylix that referenced this pull request Nov 9, 2024
Link: danth#613

Fixes: 6863412 ("foot: disable faulty check (danth#576)")
trueNAHO added a commit that referenced this pull request Nov 13, 2024
Link: #613

Fixes: 6863412 ("foot: disable faulty check (#576)")
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
Closes: danth#571

Approved-by: Daniel Thwaites <[email protected]>
Reviewed-by: NAHO <[email protected]>
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
Link: danth#613

Fixes: 6863412 ("foot: disable faulty check (danth#576)")
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
Closes: danth#571

Approved-by: Daniel Thwaites <[email protected]>
Reviewed-by: NAHO <[email protected]>
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
Link: danth#613

Fixes: 6863412 ("foot: disable faulty check (danth#576)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants