-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
foot: disable faulty check #576
Conversation
Unless we need to update this input or users override this input with
It might be easier and better to wait some time for a potential upstream fix. If this becomes a bigger problem and upstream takes too long to fix this, we could apply this temporary hotfix. |
I agree. |
The issue is still there, how to use your pull request as the flake input? |
You need to change the input to the repo where the pr is coming from (ie |
Apparently this is still an issue. |
67e0b4f
to
c0099d7
Compare
So I've changed the fix to simply pinning the tinted-theming/foot repo. Maybe this can actually be merged? |
c0099d7
to
658cda9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the copy-paste mistake, this PR LGTM:
Reviewed-by: NAHO <[email protected]>
Co-authored-by: NAHO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: NAHO <[email protected]>
The CI of 6863412 is failing for some reason... |
Well, I did not update the lockfile. That much is true. |
Closes: danth#571 Approved-by: Daniel Thwaites <[email protected]> Reviewed-by: NAHO <[email protected]>
Closes: danth#571 Approved-by: Daniel Thwaites <[email protected]> Reviewed-by: NAHO <[email protected]>
This solves #571. But since this is only a temporary fix, it does not need to be merged. See SenchoPens/base16.nix#15
There may be a way to do this better, but at least it works for me.