Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistent color between terminals (foot & kitty) #567

Closed
psynyde opened this issue Sep 22, 2024 · 5 comments · Fixed by #588
Closed

bug: inconsistent color between terminals (foot & kitty) #567

psynyde opened this issue Sep 22, 2024 · 5 comments · Fixed by #588
Labels
bug Something isn't working properly

Comments

@psynyde
Copy link

psynyde commented Sep 22, 2024

image

As seen in the preview same colorscheme generating different terminal colors for foot (left) and kitty(right) (foot has the correct coloring). also kitty's wiki also suggests the same thing.
this is the color pallet i'm using to generate colors:

    lackluster = {
      scheme = "Lackluster dark";
      author = "PsyNyde/Slugbyte(oc)";
      base00 = "#101010"; # background
      base01 = "#080808"; # (Black)
      base02 = "#191919"; # (Bright Black)
      base03 = "#2a2a2a"; # (gray)
      base04 = "#555555"; # (light gray)
      base05 = "#deeeed"; # foreground
      base06 = "#f0f0f0"; # (light foreground)
      base07 = "#ffffff"; # (lightest foreground)
      base08 = "#e64a6b"; # (Bright red)
      base09 = "#e69b7b"; # (Orange)
      base0A = "#f0c674"; # (Yellow)
      base0B = "#789978"; # (Green)
      base0C = "#6f8595"; # (Cyan)
      base0D = "#7788AA"; # (Blue)
      base0E = "#b86cd4"; # (magenta)
      base0F = "#e64a6b"; # (Dark red)
    };
@trueNAHO
Copy link
Collaborator

Related: #249

@psynyde
Copy link
Author

psynyde commented Oct 2, 2024

@danth @trueNAHO looks like the bug was caused by tinted-kitty template not matching specs. After tinted-theming/tinted-kitty#4 is merged into main, it should be fixed. (edit. it has been merged)

However, the pr also suggests 256 variants will be deprecated and removed soon, which will break stylix.targets.kitty.variant256Colors if I'm not being wrong. I’d love to hear your thoughts on this.

trueNAHO added a commit to trueNAHO/stylix that referenced this issue Oct 7, 2024
trueNAHO added a commit to trueNAHO/stylix that referenced this issue Oct 7, 2024
trueNAHO added a commit to trueNAHO/stylix that referenced this issue Oct 7, 2024
@trueNAHO
Copy link
Collaborator

trueNAHO commented Oct 7, 2024

looks like the bug was caused by tinted-kitty template not matching specs. After tinted-theming/tinted-kitty#4 is merged into main, it should be fixed. (edit. it has been merged)

Does #588 resolve the issue?

However, the pr also suggests 256 variants will be deprecated and removed soon, which will break stylix.targets.kitty.variant256Colors if I'm not being wrong.

Thanks for pointing this out. I suggest Stylix should deprecate the stylix.targets.kitty.variant256Colors option, following upstream decisions. Feel free to submit a PR.

trueNAHO added a commit that referenced this issue Oct 9, 2024
@psynyde
Copy link
Author

psynyde commented Oct 9, 2024

Hey @trueNAHO, sorry to bother you again, but after updating Stylix to the latest commit, it seems like I'm encountering the same issue as in #576. From my research, it looks like the problem stems from this commit in the tinted-kitty repository, where they updated the templates/config.yaml file. This seems to be the same issue that previously affected tinted-foot.

After checking the tinted repositories Stylix depends on (i.e. foot, kitty & tmux) ,it looks like updating any of their respective inputs will cause Stylix to break.

I can try to submit a pr to use local template instead of relying on external repo which will make it easier to maintain and update template when needed imo. but I'm not sure if this is the best way to handle this and I'm pretty new to nix so the pr can be a bit rough

@trueNAHO
Copy link
Collaborator

trueNAHO commented Oct 9, 2024

after updating Stylix to the latest commit, it seems like I'm encountering the same issue as in #576. From my research, it looks like the problem stems from this commit in the tinted-kitty repository, where they updated the templates/config.yaml file. This seems to be the same issue that previously affected tinted-foot.

After checking the tinted repositories Stylix depends on (i.e. foot, kitty & tmux) ,it looks like updating any of their respective inputs will cause Stylix to break.

Thanks for all the usefull input.

I can try to submit a pr to use local template instead of relying on external repo which will make it easier to maintain and update template when needed imo. but I'm not sure if this is the best way to handle this and I'm pretty new to nix so the pr can be a bit rough

Considering that the roadmap eventually causes Stylix to implement all templates without relying on external dependencies, it might be easiest to lock the current dependency versions to avoid wasted maintenance effort.

I am already looking into this. I will try to properly resolve this today.

-- #571 (comment)

@trueNAHO trueNAHO changed the title bug: inconsistant color between terminals (foot & kitty) bug: inconsistent color between terminals (foot & kitty) Oct 9, 2024
trueNAHO added a commit to trueNAHO/stylix that referenced this issue Oct 9, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
trueNAHO added a commit that referenced this issue Oct 11, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: #534
[2]: #567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: #571
Link: #589
Mikilio pushed a commit to Mikilio/stylix that referenced this issue Nov 4, 2024
Mikilio pushed a commit to Mikilio/stylix that referenced this issue Nov 4, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
mateusauler pushed a commit to mateusauler/stylix that referenced this issue Nov 17, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this issue Nov 17, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
mateusauler pushed a commit to mateusauler/stylix that referenced this issue Nov 20, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this issue Nov 20, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants