-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: inconsistent color between terminals (foot & kitty) #567
Comments
Related: #249 |
@danth @trueNAHO looks like the bug was caused by tinted-kitty template not matching specs. After tinted-theming/tinted-kitty#4 is merged into main, it should be fixed. (edit. it has been merged) However, the pr also suggests 256 variants will be deprecated and removed soon, which will break |
Does #588 resolve the issue?
Thanks for pointing this out. I suggest Stylix should deprecate the |
Hey @trueNAHO, sorry to bother you again, but after updating Stylix to the latest commit, it seems like I'm encountering the same issue as in #576. From my research, it looks like the problem stems from this commit in the tinted-kitty repository, where they updated the templates/config.yaml file. This seems to be the same issue that previously affected tinted-foot. After checking the tinted repositories Stylix depends on (i.e. foot, kitty & tmux) ,it looks like updating any of their respective inputs will cause Stylix to break. I can try to submit a pr to use local template instead of relying on external repo which will make it easier to maintain and update template when needed imo. but I'm not sure if this is the best way to handle this and I'm pretty new to nix so the pr can be a bit rough |
Thanks for all the usefull input.
Considering that the roadmap eventually causes Stylix to implement all templates without relying on external dependencies, it might be easiest to lock the current dependency versions to avoid wasted maintenance effort.
|
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: #534 [2]: #567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: #571 Link: #589
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
As seen in the preview same colorscheme generating different terminal colors for foot (left) and kitty(right) (foot has the correct coloring). also kitty's wiki also suggests the same thing.
this is the color pallet i'm using to generate colors:
The text was updated successfully, but these errors were encountered: