[dagster-azure]: log manager metadata represented as namedtuple instead of json string #27000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit a77f213. |
mlarose
changed the title
mlarose
force-pushed
the
mlarose/AD-721-tests
branch
from
7d5a8de to
c8b18af
Compare
mlarose
force-pushed
the
mlarose/AD-721_no_json_serialization
branch
2 times, most recently
from
08d7f76 to
1338f60
Compare
…ad of json string
mlarose
force-pushed
the
mlarose/AD-721-tests
branch
from
c8b18af to
522fea1
Compare
mlarose
force-pushed
the
mlarose/AD-721_no_json_serialization
branch
from
1338f60 to
a77f213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Before: log_manager_metadata was passed as a json string
After: log_manager_metadata is stored as a serdes serializable namedtuple and has its own graphene objecttype representation.
See #26982