[dagster-azure]: AzureBlobComputeLogManager provides alternative way to retrieve logs #26982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
mlarose
changed the title
mlarose
force-pushed
the
mlarose/AD-721-stack
branch
from
faf19e9 to
8500b32
Compare
dpeng817
reviewed
Jan 13, 2025
python_modules/dagster/dagster/_core/storage/cloud_storage_compute_log_manager.py
Show resolved
Hide resolved
dpeng817
reviewed
Jan 13, 2025
python_modules/dagster/dagster/_core/storage/cloud_storage_compute_log_manager.py
Show resolved
Hide resolved
dpeng817
reviewed
Jan 13, 2025
dpeng817
reviewed
Jan 13, 2025
python_modules/libraries/dagster-azure/dagster_azure/blob/compute_log_manager.py
Show resolved
Hide resolved
dpeng817
requested changes
Jan 13, 2025
dpeng817
reviewed
Jan 13, 2025
python_modules/dagster/dagster/_core/storage/cloud_storage_compute_log_manager.py
Show resolved
Hide resolved
mlarose
added a commit
that referenced
this pull request
Jan 16, 2025
) ## Summary & Motivation External cloud storage based compute log managers are often configured to only collect and show the url. However, in the case of the AzureBlobComputeLogManager, the provided URL will not be clickable if the storage account or container are private, which is a reasonable choice for commercial users using this feature for security and compliance on Dagster+. This supports these users by providing both a more easily readable path and a clickable shell command to retrieve the log locally. How this is implemented is by adding new fields to CapturedLogData to pass the path as well as extra azure specific information so that the frontend can render the shell cmd. ## Note to reviewers This is a rework of #26982 - applying the changes requested and discussed. ## How I Tested These Changes - dagster dev local (with the AzureBlobComputeLogManager as well as the default log manager to ensure other code paths aren't broken). - added testing of new fields in integration tests ## Changelog - [dagster-azure] AzureBlobComputeLogManager provides shell command to download logs.
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…ster-io#27090) ## Summary & Motivation External cloud storage based compute log managers are often configured to only collect and show the url. However, in the case of the AzureBlobComputeLogManager, the provided URL will not be clickable if the storage account or container are private, which is a reasonable choice for commercial users using this feature for security and compliance on Dagster+. This supports these users by providing both a more easily readable path and a clickable shell command to retrieve the log locally. How this is implemented is by adding new fields to CapturedLogData to pass the path as well as extra azure specific information so that the frontend can render the shell cmd. ## Note to reviewers This is a rework of dagster-io#26982 - applying the changes requested and discussed. ## How I Tested These Changes - dagster dev local (with the AzureBlobComputeLogManager as well as the default log manager to ensure other code paths aren't broken). - added testing of new fields in integration tests ## Changelog - [dagster-azure] AzureBlobComputeLogManager provides shell command to download logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
External cloud storage based compute log managers are often configured to only collect and show the url. However, in the case of the AzureBlobComputeLogManager, the provided URL will not be clickable if the storage account or container are private, which is a reasonable choice for commercial users using this feature for security and compliance on Dagster+.
This supports these users by providing both a more easily readable path and a clickable shell command to retrieve the log locally.
How this is implemented is by adding new fields to CapturedLogData to pass the path as well as extra azure specific information so that the frontend can render the shell cmd.
Notes to reviewers
How I Tested These Changes
dagster devlocal (with the AzureBlobComputeLogManager as well as the default log manager to ensure other code paths aren't broken).Changelog