Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pool info button in the run header on the run view #26965

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

prha
Copy link
Member

@prha prha commented Jan 9, 2025

Summary & Motivation

Adds pool information to the run header to help with debugging.

Uploading Screen Recording 2025-01-23 at 11.20.29 AM.mov…

How I Tested These Changes

Inspection, saw present on new pool-limited runs.

@prha prha changed the title runs ui Adds a pool info button in the run header on the run view Jan 9, 2025
@prha prha changed the title Adds a pool info button in the run header on the run view Add a pool info button in the run header on the run view Jan 9, 2025
@prha prha changed the title Add a pool info button in the run header on the run view add a pool info button in the run header on the run view Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-asmipc038-elementl.vercel.app
https://prha-run-pools-ui.core-storybook.dagster-docs.io

Built with commit dbe80cb.
This pull request is being automatically deployed with vercel-action

@prha prha force-pushed the prha/run_pools_graphql branch from 4dacceb to a8ac3e7 Compare January 10, 2025 01:18
@prha prha force-pushed the prha/run_pools_ui branch from 480d710 to 909157a Compare January 10, 2025 01:18
@prha prha force-pushed the prha/run_pools_graphql branch from a8ac3e7 to 3d16333 Compare January 10, 2025 23:23
@prha prha force-pushed the prha/run_pools_ui branch from 909157a to f30e1ed Compare January 10, 2025 23:23
@prha prha force-pushed the prha/run_pools_graphql branch from 3d16333 to a4ee6b4 Compare January 16, 2025 00:03
@prha prha force-pushed the prha/run_pools_ui branch from f30e1ed to 86c1e51 Compare January 16, 2025 00:03
@prha prha force-pushed the prha/run_pools_graphql branch from a4ee6b4 to ebd3269 Compare January 16, 2025 00:20
@prha prha force-pushed the prha/run_pools_ui branch from 86c1e51 to 1314a62 Compare January 16, 2025 00:20
@prha prha force-pushed the prha/run_pools_graphql branch from ebd3269 to a81756e Compare January 16, 2025 01:11
@prha prha force-pushed the prha/run_pools_ui branch from 1314a62 to 840e884 Compare January 16, 2025 01:11
@prha prha force-pushed the prha/run_pools_graphql branch from a81756e to b202de6 Compare January 16, 2025 20:23
@prha prha force-pushed the prha/run_pools_ui branch from 840e884 to 558acb1 Compare January 16, 2025 20:23
@prha prha force-pushed the prha/run_pools_graphql branch from b202de6 to 46e8b90 Compare January 17, 2025 01:08
@prha prha force-pushed the prha/run_pools_ui branch from 558acb1 to a169ead Compare January 17, 2025 01:08
@prha prha changed the base branch from prha/ui_pool_reference to prha/run_pools_graphql January 20, 2025 00:28
@prha prha force-pushed the prha/run_pools_graphql branch from dbaa24d to 770bc20 Compare January 21, 2025 17:58
@prha prha force-pushed the prha/run_pools_ui branch from 3e86416 to 3f350c4 Compare January 21, 2025 17:58
@prha prha force-pushed the prha/run_pools_graphql branch from 770bc20 to 58c2b8f Compare January 21, 2025 19:58
@prha prha force-pushed the prha/run_pools_ui branch from 3f350c4 to 44a9628 Compare January 21, 2025 19:58
@prha prha force-pushed the prha/run_pools_graphql branch from 58c2b8f to 6a319db Compare January 22, 2025 01:58
@prha prha force-pushed the prha/run_pools_ui branch from 44a9628 to 30ce73f Compare January 22, 2025 01:58
@prha prha force-pushed the prha/run_pools_graphql branch from 6a319db to 8090325 Compare January 22, 2025 19:04
@prha prha force-pushed the prha/run_pools_ui branch from 30ce73f to 49a6f83 Compare January 22, 2025 19:04
@prha prha force-pushed the prha/run_pools_graphql branch from 8090325 to bf6cadf Compare January 22, 2025 19:26
@prha prha force-pushed the prha/run_pools_ui branch from 49a6f83 to 9f644f3 Compare January 22, 2025 19:26
@prha prha force-pushed the prha/run_pools_graphql branch from bf6cadf to 9d0d248 Compare January 22, 2025 21:11
@prha prha force-pushed the prha/run_pools_ui branch from 9f644f3 to 9c9353d Compare January 22, 2025 21:11
@prha prha force-pushed the prha/run_pools_graphql branch from 9d0d248 to 4325ef4 Compare January 22, 2025 23:21
@prha prha force-pushed the prha/run_pools_ui branch from 9c9353d to c5ff268 Compare January 22, 2025 23:22
@prha prha force-pushed the prha/run_pools_graphql branch from 4325ef4 to 3f48052 Compare January 23, 2025 18:59
@prha prha force-pushed the prha/run_pools_ui branch from c5ff268 to cb49dbb Compare January 23, 2025 18:59
@prha prha force-pushed the prha/run_pools_graphql branch from 3f48052 to ef602c4 Compare January 23, 2025 19:43
@prha prha force-pushed the prha/run_pools_ui branch from cb49dbb to 777f054 Compare January 23, 2025 19:43
prha added 3 commits January 23, 2025 14:08
[INTERNAL_BRANCH=prha/add_pool_ui_gating]
@prha prha force-pushed the prha/run_pools_graphql branch from ef602c4 to 0a38a39 Compare January 23, 2025 22:09
@prha prha force-pushed the prha/run_pools_ui branch from 777f054 to dbe80cb Compare January 23, 2025 22:09
Base automatically changed from prha/run_pools_graphql to master January 24, 2025 17:25
@prha prha requested a review from bengotow January 24, 2025 18:34
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks solid!

@prha prha merged commit f46f14f into master Jan 24, 2025
1 of 2 checks passed
@prha prha deleted the prha/run_pools_ui branch January 24, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants