Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out pool detailed info into a standalone settings page #26805

Open
wants to merge 1 commit into
base: prha/ui_pool_reference
Choose a base branch
from

Conversation

prha
Copy link
Member

@prha prha commented Jan 3, 2025

Summary & Motivation

With #26804, we're directing more attention to the settings for specific pools.

This PR creates a new dedicated view for specific pool information (was previously in a dialog).

How I Tested These Changes

BK

Changelog

Creates a standalone view for specific pool info

Copy link

github-actions bot commented Jan 3, 2025

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-2k0hws45o-elementl.vercel.app
https://prha-ui-instance-page.core-storybook.dagster-docs.io

Built with commit e7dc76b.
This pull request is being automatically deployed with vercel-action

@prha prha force-pushed the prha/ui_pool_reference branch from 18c1cfc to c01da8d Compare January 6, 2025 20:04
@prha prha force-pushed the prha/ui_instance_page branch from c5aaa65 to d269905 Compare January 6, 2025 20:04
@prha prha force-pushed the prha/ui_pool_reference branch from c01da8d to 15bc61b Compare January 6, 2025 20:52
@prha prha force-pushed the prha/ui_instance_page branch from d269905 to 05cbe94 Compare January 6, 2025 20:52
@prha prha force-pushed the prha/ui_pool_reference branch from 15bc61b to 81fd01b Compare January 6, 2025 22:06
@prha prha force-pushed the prha/ui_instance_page branch from 05cbe94 to f508458 Compare January 6, 2025 22:06
@prha prha force-pushed the prha/ui_pool_reference branch from 81fd01b to 948ce8f Compare January 7, 2025 17:17
@prha prha force-pushed the prha/ui_instance_page branch from f508458 to 36ef1c1 Compare January 7, 2025 17:17
@prha prha force-pushed the prha/ui_pool_reference branch from 948ce8f to e95b257 Compare January 7, 2025 18:54
@prha prha force-pushed the prha/ui_instance_page branch from 36ef1c1 to 4eb991b Compare January 7, 2025 18:54
@prha prha force-pushed the prha/ui_pool_reference branch from e95b257 to 02311b6 Compare January 7, 2025 22:53
@prha prha force-pushed the prha/ui_instance_page branch from 4eb991b to b50b563 Compare January 7, 2025 22:54
@prha prha force-pushed the prha/ui_pool_reference branch from 02311b6 to fd552b6 Compare January 8, 2025 04:25
@prha prha force-pushed the prha/ui_instance_page branch from b50b563 to 53edb22 Compare January 8, 2025 04:25
@prha prha force-pushed the prha/ui_pool_reference branch from fd552b6 to f1ee75f Compare January 8, 2025 04:49
@prha prha force-pushed the prha/ui_instance_page branch 2 times, most recently from 87c0a6f to d24cf46 Compare January 8, 2025 04:59
@prha prha force-pushed the prha/ui_pool_reference branch from f1ee75f to 3c5deda Compare January 8, 2025 05:13
@prha prha force-pushed the prha/ui_instance_page branch from d24cf46 to 80d3b13 Compare January 8, 2025 05:13
@prha prha force-pushed the prha/ui_pool_reference branch from 3c5deda to 9fa4539 Compare January 8, 2025 05:17
@prha prha force-pushed the prha/ui_instance_page branch 2 times, most recently from c3e9fa3 to 7d4debd Compare January 8, 2025 05:26
@prha prha force-pushed the prha/ui_pool_reference branch from 9fa4539 to 16f3f44 Compare January 8, 2025 19:52
@prha prha force-pushed the prha/ui_instance_page branch from 7d4debd to 7903c5f Compare January 8, 2025 19:52
@prha prha force-pushed the prha/ui_pool_reference branch from 16f3f44 to dc05156 Compare January 8, 2025 20:36
@prha prha force-pushed the prha/ui_instance_page branch 2 times, most recently from c02af46 to a068773 Compare January 8, 2025 20:48
@prha prha force-pushed the prha/ui_pool_reference branch from dc05156 to a013444 Compare January 9, 2025 03:43
@prha prha force-pushed the prha/ui_instance_page branch from a068773 to 4d471e9 Compare January 9, 2025 03:43
@prha prha force-pushed the prha/ui_pool_reference branch from a013444 to 2d2cbff Compare January 9, 2025 03:58
@prha prha force-pushed the prha/ui_instance_page branch from 4d471e9 to 859dd4c Compare January 9, 2025 03:58
@prha prha changed the title standalone concurrency page split out concurrency key detailed info into a standalone settings page Jan 9, 2025
@prha prha marked this pull request as ready for review January 9, 2025 06:10
@prha prha changed the title split out concurrency key detailed info into a standalone settings page split out pool detailed info into a standalone settings page Jan 9, 2025
@prha prha force-pushed the prha/ui_pool_reference branch from 2d2cbff to 8e5792c Compare January 10, 2025 01:17
@prha prha force-pushed the prha/ui_instance_page branch from 859dd4c to be163cf Compare January 10, 2025 01:17
@prha prha force-pushed the prha/ui_pool_reference branch from 8e5792c to 9eacecf Compare January 10, 2025 23:23
@prha prha force-pushed the prha/ui_instance_page branch from be163cf to e7dc76b Compare January 10, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant