-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): PR command build_test #619
Conversation
demo: mwangggg#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any other feedback @tthvo ?
LGTM but since @ebaron does more of the maintainer work here, I think he should at least take a look over the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mwangggg, very sorry for taking so long to get to this. Looks great overall, I just have a couple questions below. I really like splitting the workflows into separate PR and push files. This should improve security as well since the Quay.io secret isn't available with pull_request_target
events anymore.
5f46873
to
26efe7e
Compare
demo: mwangggg#2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! @tthvo any other comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Nice job @mwangggg! Thankss!
@mwangggg I noticed the CI is failing with the following warning when trying to push the test images to GHCR: I think we need to add something like this when calling the reusable workflow:
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #618