feat(openshift): custom extra labels/annotations on deployments/pods

[OpenGuidou]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

---

Fixes: #630

Description of the change:

This change adds allows the users to provide additional labels and annotations to be used in the cryostat deployment and pod.

Motivation for the change:

This change is helpful because some environment have a strong labeling policy for all resources.

[andrewazores]

/build_test

[andrewazores]

https://github.com/cryostatio/cryostat-operator/actions/runs/6263310857

[andrewazores]

Ah right, that CI command is currently not working: #619 (comment)

[ebaron]

Hi @OpenGuidou, thank you for your contribution! Excellent work as well. I have some comments below, but more generally, do you think it makes sense to have a separate set of labels and annotations for the reports deployment (if enabled)? Typically, we'd put any properties that affect the reports deployment under the ReportOptions property.

[andrewazores]

I think this looks good. @ebaron would you want the ingresses/services/routes to also have customizable labels/annotations like this or are you OK with it just going as far as pod/deployment for now?

[OpenGuidou]

I think this looks good. @ebaron would you want the ingresses/services/routes to also have customizable labels/annotations like this or are you OK with it just going as far as pod/deployment for now?

For that one, it's already possible via https://github.com/cryostatio/cryostat-operator/blob/main/api/v1beta1/cryostat_types.go#L226 and https://github.com/cryostatio/cryostat-operator/blob/main/api/v1beta1/cryostat_types.go#L292

[ebaron]

@OpenGuidou looks good! Just noticed one more thing. Could you run make bundle to regenerate the CSV to include these new properties? We recently upgraded to Operator SDK 1.31.0, so if you have another version installed locally you'll need to upgrade.

[OpenGuidou]

@OpenGuidou looks good! Just noticed one more thing. Could you run make bundle to regenerate the CSV to include these new properties? We recently upgraded to Operator SDK 1.31.0, so if you have another version installed locally you'll need to upgrade.

Ha I missed that, it's now done

[ebaron]

Excellent work @OpenGuidou! Thank you very much for the contribution!

[ebaron]

@OpenGuidou Sorry one more thing. We require that all commits be signed in order for me to merge this PR:
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[OpenGuidou]

@OpenGuidou Sorry one more thing. We require that all commits be signed in order for me to merge this PR: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

Done !