Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DOC-11819: remove playbook references to tutorials. #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] DOC-11819: remove playbook references to tutorials. #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions antora-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ site:
{ "title": "Autonomous Operator", "components": ["operator"] },
{ "title": "CMOS", "components": ["cmos"] },
{ "title": "SDKs", "startPage": "home::sdk.adoc", "components": ["*-sdk", "cxx-txns", "elasticsearch-connector", "kafka-connector", "spark-connector", "tableau-connector", "power-bi-connector", "sdk-extensions"] },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove the trailing , here.

(Though this is in yaml, it's actually a string representation of JSON for, er... historical reasons, I imagine...)
And I think JSON spec strictly speaking doesn't allow trailing commas, even though JS itself does, 🤷 hey ho.

{ "title": "Tutorials", "startPage": "tutorials::index.adoc", "components": ["tutorials"] }
]
git:
ensure_git_suffix: false
Expand Down Expand Up @@ -124,18 +123,8 @@ content:
# - url: https://[email protected]/couchbase/docs-cloud-native
- url: https://github.com/couchbase/docs-cloud-native
branches: [cloud-native-2.2]
# - url: https://github.com/couchbaselabs/tutorials
- url: https://github.com/couchbase/developer-content
- url: https://github.com/couchbaselabs/tutorial-template
- url: https://github.com/couchbaselabs/mobile-travel-sample
branches: [master]
start_path: content
# - url: https://github.com/couchbaselabs/hotel-finder-react-native
# - url: https://github.com/couchbaselabs/hotel-lister-cordova
# - url: https://github.com/couchbaselabs/tutorials-contrib
- url: https://github.com/couchbaselabs/mobile-training-todo
branches: tutorials
start_path: content
- url: https://github.com/couchbaselabs/UniversityLister-Android
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, I think the following modules are all tutorial content too.

And looking at the names vaguely reminds me of a chat a while back with @RichardSmedley... didn't you find some reason for which this content was spared, as it's still required by PM / not yet adopted by Dev Advocacy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be right, but I can't remember - DA are at SKO this week, so we may not get a quick answer on that.

start_path: content
- url: https://github.com/couchbaselabs/userprofile-couchbase-mobile
Expand Down