Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DOC-11819: remove playbook references to tutorials. #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElliotFrancisHunter
Copy link
Contributor

This is an attempt to fix the following ticket: https://issues.couchbase.com/browse/DOC-11819

https://docs.couchbase.com/tutorials/userprofile-query-android/userprofile_query.html

https://docs.couchbase.com/tutorials/mobile-travel-tutorial/swift/installation/travel-mobile-app.html

On triaging: https://issues.couchbase.com/browse/DOC-10798

I discovered a few orphan pages, it is my understanding that tutorials have moved to the developer advocacy side which would explain the broken appearance of the pages (screenshots attached). No nav bars being one reason.

@ElliotFrancisHunter ElliotFrancisHunter added bug Something isn't working help wanted Extra attention is needed labels Jan 30, 2024
@ElliotFrancisHunter ElliotFrancisHunter self-assigned this Jan 30, 2024
Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good with 1 technical tweak, but let's see what other reviewers bring to table!

# - url: https://github.com/couchbaselabs/tutorials-contrib
- url: https://github.com/couchbaselabs/mobile-training-todo
branches: tutorials
start_path: content
- url: https://github.com/couchbaselabs/UniversityLister-Android
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, I think the following modules are all tutorial content too.

And looking at the names vaguely reminds me of a chat a while back with @RichardSmedley... didn't you find some reason for which this content was spared, as it's still required by PM / not yet adopted by Dev Advocacy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be right, but I can't remember - DA are at SKO this week, so we may not get a quick answer on that.

@@ -22,7 +22,6 @@ site:
{ "title": "Autonomous Operator", "components": ["operator"] },
{ "title": "CMOS", "components": ["cmos"] },
{ "title": "SDKs", "startPage": "home::sdk.adoc", "components": ["*-sdk", "cxx-txns", "elasticsearch-connector", "kafka-connector", "spark-connector", "tableau-connector", "power-bi-connector", "sdk-extensions"] },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove the trailing , here.

(Though this is in yaml, it's actually a string representation of JSON for, er... historical reasons, I imagine...)
And I think JSON spec strictly speaking doesn't allow trailing commas, even though JS itself does, 🤷 hey ho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants