-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] DOC-11819: remove playbook references to tutorials. #739
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good with 1 technical tweak, but let's see what other reviewers bring to table!
# - url: https://github.com/couchbaselabs/tutorials-contrib | ||
- url: https://github.com/couchbaselabs/mobile-training-todo | ||
branches: tutorials | ||
start_path: content | ||
- url: https://github.com/couchbaselabs/UniversityLister-Android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're here, I think the following modules are all tutorial content too.
And looking at the names vaguely reminds me of a chat a while back with @RichardSmedley... didn't you find some reason for which this content was spared, as it's still required by PM / not yet adopted by Dev Advocacy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be right, but I can't remember - DA are at SKO this week, so we may not get a quick answer on that.
@@ -22,7 +22,6 @@ site: | |||
{ "title": "Autonomous Operator", "components": ["operator"] }, | |||
{ "title": "CMOS", "components": ["cmos"] }, | |||
{ "title": "SDKs", "startPage": "home::sdk.adoc", "components": ["*-sdk", "cxx-txns", "elasticsearch-connector", "kafka-connector", "spark-connector", "tableau-connector", "power-bi-connector", "sdk-extensions"] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to remove the trailing ,
here.
(Though this is in yaml, it's actually a string representation of JSON for, er... historical reasons, I imagine...)
And I think JSON spec strictly speaking doesn't allow trailing commas, even though JS itself does, 🤷 hey ho.
This is an attempt to fix the following ticket: https://issues.couchbase.com/browse/DOC-11819
https://docs.couchbase.com/tutorials/userprofile-query-android/userprofile_query.html
https://docs.couchbase.com/tutorials/mobile-travel-tutorial/swift/installation/travel-mobile-app.html
On triaging: https://issues.couchbase.com/browse/DOC-10798
I discovered a few orphan pages, it is my understanding that tutorials have moved to the developer advocacy side which would explain the broken appearance of the pages (screenshots attached). No nav bars being one reason.