chore: enable std feature when mocks is enabled
#926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice catch. Thanks 👌
I've reopened this for no_std envs: #329
Just plz add a unclog, then we're good to merge.
`mocks` feature results in use of `Timestamp::now` which is only defined when `std` feature is enabled. Make `std` implied by `mocks`.
|
Done. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
=======================================
Coverage 67.56% 67.56%
=======================================
Files 131 131
Lines 16283 16283
=======================================
Hits 11001 11001
Misses 5282 5282 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
`mocks` feature results in use of `Timestamp::now` which is only defined when `std` feature is enabled. Make `std` implied by `mocks`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocksfeature results in use ofTimestamp::nowwhich is onlydefined when
stdfeature is enabled. Makestdimplied bymocks.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.