Skip to content

Commit

Permalink
chore: enable std feature when mocks is enabled
Browse files Browse the repository at this point in the history
`mocks` feature results in use of `Timestamp::now` which is only
defined when `std` feature is enabled.  Make `std` implied by `mocks`.
  • Loading branch information
mina86 committed Oct 18, 2023
1 parent 476937b commit 224eb00
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- Fix compilation issue with Wasm envs because of floats
- Use `serde-json-wasm` dependency instead of `serde-json` for no-floats support
- Add CI test to include CosmWasm compilation check
([/#850](https://github.com/cosmos/ibc-rs/issues/850))
([\#850](https://github.com/cosmos/ibc-rs/issues/850))
9 changes: 9 additions & 0 deletions .changelog/unreleased/improvements/926_mocks_implies_std.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
- Change `mocks` feature to imply `std` since it requires
Timestamp::now to work.
([\#926](https://github.com/cosmos/ibc-rs/pull/926))

<!--
Add your entry's details here (in Markdown format).
If you don't change this message, or if this file is empty, the entry will
not be created. -->
4 changes: 2 additions & 2 deletions crates/ibc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ default = ["std"]
std = [
"ibc-proto/std",
"ics23/std",
"serde/std",
"serde/std",
"tracing/std",
"prost/std",
"bytes/std",
Expand All @@ -46,7 +46,7 @@ schema = ["dep:schemars", "serde", "std"]

# This feature grants access to development-time mocking libraries, such as `MockContext` or `MockHeader`.
# Depends on the `testgen` suite for generating Tendermint light blocks.
mocks = ["tendermint-testgen", "tendermint/clock", "parking_lot", "typed-builder"]
mocks = ["tendermint-testgen", "parking_lot", "typed-builder", "std"]

[dependencies]
# Proto definitions for all IBC-related interfaces, e.g., connections or channels.
Expand Down

0 comments on commit 224eb00

Please sign in to comment.