Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun offset tracking #41

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Sun offset tracking #41

merged 6 commits into from
Feb 1, 2024

Conversation

Carifio24
Copy link
Member

This PR updates the tracking behavior when not centered on the Sun. Currently, we just keep the camera in place. This PR updates the behavior so that the "offset" of the current position from the Sun (offset here meaning the screen-space distance) is kept constant. The offset amount is updated each time we get a pointer up event on the canvas.

@patudom
Copy link
Contributor

patudom commented Feb 1, 2024

  • If user changes location, WWT stops trying to keep your position relative to the sun steady. We should watch for that.
  • If the Sun is offset from center, when user changes time with the slider, it's still pretty jittery (but is ok when playing time). See if this can be improved? - moved to new issue

@patudom patudom merged commit 9fae6da into cosmicds:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants