Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big stuff (in the commit called "Coordinate sun tracking & centering UI")
With Jon's #41 update to allow tracking off center, we needed to coordinate the switches and offer the user a way to center back on the Sun. It ended up being way more complicated than I thought it would be, and I'm not sure my changes are bulletproof, but everything seems to behave how I intended it to. It would be good if someone could please check and make sure everything makes sense. I had to delete/disable some things where I was not 100% sure what they were meant to do, and it's possible I left in things or added things that are not really necessary. This is what I intended:
toggleTrackSun = true
), we need to make sure that tracking is active whether we are centered on the Sun (trackSun
) or not centered (trackSunOffset
).trackSun
ortrackSunOffset
sunCenteredTracking = true
), disable but check the "Center Sun" box. (I disable it because it doesn't make sense to be able to uncheck the "Center Sun" box because it's not like we can pick a random point to send them to, now that centering & tracking are 2 separate things).activePointer
because while I was mousing down and panning around in WWT, the sun tracking toggle would automatically change itself to off, so I only try to settrackingSun
ifactivePointer = false
.Smaller stuff