added missing cameras: ENTRY for Spirit and Opportunity, SUPERCAM_RMI and LCAM for Perseverance #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing camera: ENTRY (Entry, Descent, and Landing Camera) for Spirit and Opportunity, only available on sol 1
bk7312
changed the title
bk7312
changed the title
Issue: - API unable to get photos from Perseverance LCAM (Lander Vision System Camera), LCAM only on Sol 0. - LCAM created in db/seeds.rb (line 26) but missing in spec/models/perseverance_scraper_spec.rb Fix: - Added LCAM to perseverance_scraper_spec.rb - Added LCAM to README.md Disclaimer: - I'm not familiar with the codebase/ruby and this fix is based on searching/comparing where the other Perseverance camera names are being called/used.
bk7312
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing cameras to README.md:
Added LCAM to perseverance_scraper_spec.rb