Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of things to do #1

Open
4 of 10 tasks
bk7312 opened this issue Feb 3, 2024 · 0 comments
Open
4 of 10 tasks

List of things to do #1

bk7312 opened this issue Feb 3, 2024 · 0 comments

Comments

@bk7312
Copy link
Owner

bk7312 commented Feb 3, 2024

New features

  • Light/Dark mode (currently based on prefers-color-scheme instead of toggle button)
  • Option to view photos in grid vs list and filter photos based on camera (if searched for all cameras)
  • User auth for login
  • Able to favorite a photo
  • Able to add own notes to favorited photo

Improvements

  • Refactor PhotoResults and the favorites page, create PhotoGrid component?
  • Improve UI and clean up code, i.e. remove console.log
  • Refactor search and photo results in separate pages? Then use search params for image search and server components instead of useState? (Goal: To reduce CLS, search box initially at center but jumps to the top of the page once photo results load, photo results layout also changes based on image number)
  • Use SWR or tanstack react query for data fetching to take advantage of built-in loading/error state management?
  • Refactor useFavorites and usePhotos hooks to cleanly separate repeated code and also separate the fullscreen function into a useFullscreen hook?

Issues:

Images are assumed to be square, this works most of the time but there are some images that are horizontal or vertical strips, (i.e. opportunity sol 1: ENTRY - horizontal strips, PANCAM - last few images are vertical strips)

When the screen size is large and there's only one image in PhotoResults, it shows that photo by itself in a multi column grid, to make it single column or center/enlarge the image, or leave as is?

Perseverance LCAM (Lander Vision System Camera) on sol 0, available from NASA website but not available from upstream api - PR raised corincerami/mars-photo-api#192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant