Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for copy command - from remote to local #3749

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

numcys
Copy link
Contributor

@numcys numcys commented Nov 10, 2024

What is the feature/update/fix?

Fix: Resolved convox cp Issue for Remote to Local File Copy

This update addresses an issue with the convox cp command when copying specific files from a remote container to the local filesystem. Previously, attempts to copy individual files (as opposed to entire folders) appeared to succeed, with network traffic passing, but the file would not be created on the local system. This fix ensures that single files can now be reliably copied to the local filesystem.

How to use it?

The convox cp command is used to copy files between a local machine and a container. To copy a file from a container to your local system, you’ll first need the container ID, which can be obtained with:

$ convox ps -a appName -r rackName

Then, to copy a specific file from the remote container to a local directory, use:

$ convox cp [container ID]:[remote absolute file path] [relative local file path] -a appName -r rackName

For example:

$ convox cp 5e3c8576b942:/app/foo/bar.txt foo/bar.txt -a my-app -r my-rack

Requirements

To use this feature, you must be on at least CLI and rack version 20241112202208.

  • You can check your CLI version with convox version.
  • You can update your CLI with convox update.
  • You can check your rack's version with convox rack -r rackName.
  • Update your rack to the latest version with convox rack update -r rackName.

@numcys numcys requested a review from nightfury1204 November 10, 2024 15:44
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (20241111184017@abfbd77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/helpers/tar.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             20241111184017    #3749   +/-   ##
=================================================
  Coverage                  ?   33.14%           
=================================================
  Files                     ?      182           
  Lines                     ?    20558           
  Branches                  ?        0           
=================================================
  Hits                      ?     6814           
  Misses                    ?    12596           
  Partials                  ?     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightfury1204 nightfury1204 changed the base branch from master to 20241111184017 November 11, 2024 18:41
@nightfury1204 nightfury1204 merged commit c56d732 into 20241111184017 Nov 11, 2024
4 checks passed
@nightfury1204 nightfury1204 deleted the fix/cp-cli-cmd branch November 11, 2024 18:41
@nightfury1204 nightfury1204 mentioned this pull request Nov 11, 2024
nightfury1204 pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants