Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20241111184017 #3750

Merged
merged 2 commits into from
Nov 12, 2024
Merged

20241111184017 #3750

merged 2 commits into from
Nov 12, 2024

Conversation

nightfury1204
Copy link
Collaborator

What is the feature/fix?

#3747
#3749

fix for copy from remote to local
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.14%. Comparing base (abfbd77) to head (b969cba).

Files with missing lines Patch % Lines
pkg/helpers/tar.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3750   +/-   ##
=======================================
  Coverage   33.14%   33.14%           
=======================================
  Files         182      182           
  Lines       20558    20558           
=======================================
  Hits         6814     6814           
  Misses      12596    12596           
  Partials     1148     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ntner ntner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Install and update to rack version
  • Downgrade to previous version
  • Telemetry based param groupings at install
  • Common convox rack param set variations after install
  • New application install and running with multiple resources
  • Existing application working after upgrade
  • Review and Deploy Workflows working across update
  • General and build stress-testing

  • convox cp testing
  • ECS Stop Container Stop Timeout testing

* added rack param ecs_container_stop_timeout

* changed default value of EcsContainerStopTimeout param

* adding conditional logic on parameter
@nightfury1204 nightfury1204 merged commit dcdca1f into master Nov 12, 2024
1 check was pending
@nightfury1204 nightfury1204 deleted the 20241111184017 branch November 12, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants