Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make msvc_env_cmd no-op for arm64 #4867

Merged
merged 20 commits into from
Feb 6, 2024
Merged

Make msvc_env_cmd no-op for arm64 #4867

merged 20 commits into from
Feb 6, 2024

Conversation

finnagin
Copy link
Contributor

@finnagin finnagin commented May 4, 2023 •
edited
Loading

Description

Changes msvc_env_cmd to output a warning then return an empty string when bits is "arm64".

xref: conda-forge/conda-forge.github.io#1940

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot mentioned this pull request May 4, 2023
Merged
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @finnagin.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#756), and ping the bot to refresh the PR.

isuruf
isuruf previously approved these changes May 6, 2023
View reviewed changes
jezdez
jezdez previously approved these changes May 8, 2023
View reviewed changes
@jezdez
Copy link
Member

jezdez commented May 9, 2023

pre-commit.ci autofix

@pre-commit-ci pre-commit-ci bot dismissed stale reviews from jezdez and isuruf via b2c65e4 May 9, 2023 11:00
@isuruf isuruf mentioned this pull request Jun 18, 2023
Open
18 tasks
isuruf
isuruf previously approved these changes Jul 4, 2023
View reviewed changes
@jakirkham
Copy link
Member

Sounds like we are waiting on the CLA here

Could someone please share an update on how that is going with (if possible) a rough timeline?

@finnagin
Copy link
Contributor Author

Just wanted to check in again since there hasn't been a response yet to @jakirkham's comment above.

@jezdez would you be the correct person to ask about clarification on the current status of the CLA? I'm hoping to find an answer to this question if possible.

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 29, 2023
@jakirkham
Copy link
Member

Sorry for bumping this again. Just wanted to check if there was an update

kenodegard
kenodegard previously approved these changes Dec 12, 2023
View reviewed changes
@kenodegard kenodegard enabled auto-merge (squash) December 12, 2023 03:39
isuruf
isuruf reviewed Dec 12, 2023
View reviewed changes
conda_build/windows.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled December 12, 2023 03:53

Head branch was pushed to by a user without write access

@finnagin @isuruf
Update conda_build/windows.py
3a8eb9b 
Co-authored-by: Isuru Fernando <[email protected]>
@kenodegard kenodegard merged commit e32ff65 into conda:main Feb 6, 2024
26 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@beeankha beeankha mentioned this pull request Mar 12, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@kenodegard kenodegard kenodegard approved these changes

@jezdez jezdez jezdez left review comments

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@finnagin @conda-bot @jezdez @jakirkham @kenodegard @isuruf