Skip to content

Commit

Permalink
Make msvc_env_cmd no-op for arm64 (#4867)
Browse files Browse the repository at this point in the history
Co-authored-by: Isuru Fernando <[email protected]>
  • Loading branch information
finnagin and isuruf authored Feb 6, 2024
1 parent 15971b7 commit e32ff65
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
3 changes: 3 additions & 0 deletions conda_build/windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ def msvc_env_cmd(bits, config, override=None):
"If this recipe does not use a compiler, this message is safe to ignore. "
"Otherwise, use {{compiler('<language>')}} jinja2 in requirements/build."
)
if bits not in ["64", "32"]:
log.warn(f"The legacy MSVC compiler setup does not support {bits} builds. ")
return ""
if override:
log.warn(
"msvc_compiler key in meta.yaml is deprecated. Use the new"
Expand Down
19 changes: 19 additions & 0 deletions news/4867-arm64-msvc-env-cmd-no-op
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* <news item>

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* Added a check to print an additional warning and return an empty string when bits is "arm64" in msvc_env_cmd. (#4867)

0 comments on commit e32ff65

Please sign in to comment.