Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make msvc_env_cmd no-op for arm64 #4867

Merged
merged 20 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions conda_build/windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ def msvc_env_cmd(bits, config, override=None):
"If this recipe does not use a compiler, this message is safe to ignore. "
"Otherwise, use {{compiler('<language>')}} jinja2 in requirements/build."
)
if bits == "arm64":
log.warn("The legacy MSVC compiler setup does not support arm64 builds. ")
return ""
finnagin marked this conversation as resolved.
Show resolved Hide resolved
if override:
log.warn(
"msvc_compiler key in meta.yaml is deprecated. Use the new"
Expand Down
19 changes: 19 additions & 0 deletions news/4867-arm64-msvc-env-cmd-no-op
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* <news item>

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* Added a check to print an additional warning and return an empty string when bits is "arm64" in msvc_env_cmd. (#4867)
Loading