Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deepsearch-glm #28269

Merged
merged 14 commits into from
Nov 20, 2024
Merged

add deepsearch-glm #28269

merged 14 commits into from
Nov 20, 2024

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 19, 2024

Continuation of #28093


Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@hadim hadim mentioned this pull request Nov 19, 2024
10 tasks
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/deepsearch-glm/recipe.yaml) and found it was in an excellent condition.

@hadim hadim mentioned this pull request Nov 19, 2024
10 tasks
@hadim hadim marked this pull request as ready for review November 19, 2024 02:04
@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

@h-vetinari I am trying to make pip check to work by matching the numpy constraints from upstream (https://github.com/DS4SD/deepsearch-glm/blob/v0.26.1/pyproject.toml#L30-L33).

What is the numpy strategy on c-f since 2.x? Should I respect the upstream constraints or let it free?

@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

It looks like c-f pinning is incompatible:

numpy:
  # part of a zip_keys: python, python_impl, numpy
  - 1.22 #3.9
  - 1.22 #3.10
  - 1.23 #3.11
  - 1.26 #3.12

Is that ok to set pip check to false here?

@h-vetinari
Copy link
Member

What is the numpy strategy on c-f since 2.x? Should I respect the upstream constraints or let it free?

We've been migrating for numpy 2.0 for a long time already, but it's not finished yet, which means you don't get it in staged-recipes. In this case, the upstream constraints are almost certainly wrong resp. too tight, and I would recommend patching them out. Alternatively, you could also use

numpy:
  - 2.0

in recipe/conda_build_config.yaml if you want, to mimick what the numpy 2.0 migrator does (which you can then delete once the migrator comes around).

@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

I checked the code and there is nothing specific to numpy so it's safe to let it free. So I simply patched the upstream pyproject.toml so pip check works.

Let me know what you think @h-vetinari

@hadim

This comment was marked as outdated.

@hadim

This comment was marked as resolved.

@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

LGTM @h-vetinari

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@h-vetinari h-vetinari merged commit 3768d9c into conda-forge:main Nov 20, 2024
7 checks passed
@hadim hadim deleted the deepsearch branch November 20, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants