-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deepsearch-glm #28269
add deepsearch-glm #28269
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@h-vetinari I am trying to make What is the numpy strategy on c-f since |
It looks like c-f pinning is incompatible: numpy:
# part of a zip_keys: python, python_impl, numpy
- 1.22 #3.9
- 1.22 #3.10
- 1.23 #3.11
- 1.26 #3.12 Is that ok to set |
We've been migrating for numpy 2.0 for a long time already, but it's not finished yet, which means you don't get it in staged-recipes. In this case, the upstream constraints are almost certainly wrong resp. too tight, and I would recommend patching them out. Alternatively, you could also use numpy:
- 2.0 in |
I checked the code and there is nothing specific to numpy so it's safe to let it free. So I simply patched the upstream Let me know what you think @h-vetinari |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
LGTM @h-vetinari |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Continuation of #28093
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).