Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docling and deepsearch-glm #28093

Closed
wants to merge 27 commits into from
Closed

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 3, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@hadim hadim marked this pull request as draft November 3, 2024 21:30
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 3, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/deepsearch-glm/recipe.yaml, recipes/docling/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/docling/recipe.yaml, recipes/deepsearch-glm/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/docling/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@hadim
Copy link
Member Author

hadim commented Nov 11, 2024

@conda-forge/help-python @conda-forge/help-python-c ready for review. Thank you!

The failure on Windows is due to docling depending on deepsearch-glm (but deepsearch-glm is not available on windows).

@hadim hadim marked this pull request as ready for review November 11, 2024 18:37
@hadim
Copy link
Member Author

hadim commented Nov 15, 2024

Friendly bump!

recipes/deepsearch-glm/recipe.yaml Show resolved Hide resolved
recipes/docling/recipe.yaml Show resolved Hide resolved
recipes/deepsearch-glm/recipe.yaml Show resolved Hide resolved
@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

@h-vetinari thanks for looking into it.

I will close here and open two new PRs as I am having issues building locally.

@hadim hadim closed this Nov 19, 2024
@hadim hadim deleted the docling-package branch November 19, 2024 01:32
@hadim
Copy link
Member Author

hadim commented Nov 19, 2024

This was referenced Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants