Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add streamlit-searchbox #28067

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Oct 31, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/streamlit-searchbox/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/streamlit-searchbox/meta.yaml:

  • No valid build backend found for Python recipe for package streamlit-searchbox using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@ytausch
Copy link
Contributor Author

ytausch commented Oct 31, 2024

@conda-forge/help-python ready for review!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/streamlit-searchbox/meta.yaml) and found it was in an excellent condition.

@jaimergp
Copy link
Member

Let's make the tests pass first :P

Also, this is adding a tests top-level package (see clobber warnings), so we should patch their pyproject file so tests/ is excluded from the package.

@ytausch ytausch force-pushed the streamlit-searchbox branch from 2c6bb3a to 818f623 Compare October 31, 2024 17:54
@ytausch
Copy link
Contributor Author

ytausch commented Oct 31, 2024

Hopefully, the recipe is good now. I had to upgrade the minimum streamlit version because the really old ones have incorrect dependency constraints. As a sideline, I attempt to fix that here:

long_description_content_type="text/plain",
url="https://github.com/m-wrzr/streamlit-searchbox",
- packages=setuptools.find_packages(),
+ packages=setuptools.find_packages(exclude=("tests",)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please report this upstream.

@ocefpaf ocefpaf merged commit c23ff9c into conda-forge:main Nov 1, 2024
7 checks passed
@ytausch ytausch deleted the streamlit-searchbox branch November 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants