Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Deployment #11

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Oct 5, 2024

This follow-up PR of #10 is intended to be merged after #10.

In this PR, we add a Docker deployment for the app. The pixi environment is used within the Docker container.
To allow app installation within the container, I restructured the project to be located in a Python module that is installable with pip. Unfortunately, because of limitations imposed by Streamlit, a workaround (app_proxy.py) was required for Streamlit to execute an app from a Python module.

If you want to use the Docker container today, a Docker Image has already been pushed to GHCR in my fork.

diff view for convenience

@pavelzw

@ytausch
Copy link
Contributor Author

ytausch commented Oct 5, 2024

This is the Streamlit Cloud Deployment from my fork, proving that the app_config.py hack works there as well: https://2wmcagxddiqfknnuikwyrq.streamlit.app/

.github/workflows/container.yml Outdated Show resolved Hide resolved
.github/workflows/container.yml Outdated Show resolved Hide resolved
.github/workflows/container.yml Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ytausch
Copy link
Contributor Author

ytausch commented Oct 14, 2024

@pavelzw missing your approval checkmark :)

@ytausch ytausch requested a review from pavelzw October 14, 2024 13:27
@ytausch
Copy link
Contributor Author

ytausch commented Oct 31, 2024

I have adjusted the pixi deployment to use conda packages whenever possible. This was necessary because of a pixi bug, and also a good idea in general IMO.

streamlit-searchbox (the last PyPI dependency) is currently awaiting review in staged-recipes:

Otherwise, this is ready for review! @jaimergp

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
app_proxy.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
conda_metadata_app/app.py Outdated Show resolved Hide resolved
conda_metadata_app/app.py Outdated Show resolved Hide resolved
@ytausch
Copy link
Contributor Author

ytausch commented Nov 4, 2024

Since streamlit-searchbox is now on conda-forge, I've adjusted the dependency accordingly.
Unfortunately, there is no conda-oci-mirror on PyPI yet, so I had to use the git URL in pyproject.toml.

@ytausch ytausch requested a review from jaimergp November 4, 2024 13:54
@jaimergp jaimergp merged commit f52d3d0 into Quansight-Labs:main Nov 4, 2024
2 checks passed
@jaimergp
Copy link
Collaborator

jaimergp commented Nov 4, 2024

Thanks!

@ytausch ytausch deleted the add-dockerfile branch November 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants