Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyclesperanto #23908

Merged
merged 20 commits into from
Oct 21, 2023
Merged

Add pyclesperanto #23908

merged 20 commits into from
Oct 21, 2023

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Sep 5, 2023

Adding pyclesperanto package

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@StRigaud
Copy link
Member Author

StRigaud commented Sep 5, 2023

waiting for @haesleinhuepf approval for being listed as maintainer

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyclesperanto) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pyclesperanto:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyclesperanto) and found some lint.

Here's what I've got...

For recipes/pyclesperanto:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyclesperanto) and found it was in an excellent condition.

@haesleinhuepf
Copy link
Contributor

I'm happy to maintain this together with you @StRigaud 🙌🎉

@StRigaud
Copy link
Member Author

StRigaud commented Sep 7, 2023

should be good for review once the osx issue is solved:

@StRigaud StRigaud marked this pull request as ready for review September 8, 2023 12:46
@StRigaud
Copy link
Member Author

StRigaud commented Sep 8, 2023

@conda-forge-admin, please ping conda-forge/help-c-cpp, ready for review!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-c-cpp, and so here I am doing that.

@github-actions github-actions bot added the c-cpp label Sep 8, 2023
@haesleinhuepf
Copy link
Contributor

Hi @goanpeca @jaimergp ,

can you please help us with getting this PR through? The library will become the new backend for this napari-plugin.

Thank you!

Best,
Robert

@xhochy xhochy merged commit 8b8b5f3 into conda-forge:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants