Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the package into a package manager (conda, pip, ...) #3

Closed
StRigaud opened this issue Mar 31, 2022 · 9 comments
Closed

Add the package into a package manager (conda, pip, ...) #3

StRigaud opened this issue Mar 31, 2022 · 9 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@StRigaud
Copy link
Member

No experience into this, especially with C++, Wrapper, scikit-build, OpenCL mix!

Basically, how can we make this work by simply calling

conda install pyclesperanto

or

pip install pyclesperanto

No clue what is needed nor how to do this, but still happy to help into this.

@StRigaud StRigaud added the help wanted Extra attention is needed label Mar 31, 2022
@StRigaud
Copy link
Member Author

Save for later, tutorial for publishing C++ code on pyPI

@StRigaud
Copy link
Member Author

Also more info on distribution for wheel and conda with skbuild and pybind11 here:

@StRigaud
Copy link
Member Author

pipy deployement started to be explored here:

It rely on cibuildwheel which compile wheel for multiple python version. OS, and architecture, and we can automatically ship them to pipy.
Full wheel CI can be found here.

Current issue:

  • On Linux, icd-loader is not found. If you look at how pyopencl ppl did, we can see that they rely on the ocl-icd repo with a twist
  • On Windows, for now cibuidlwheel fail during CI at setup. something is missing most likely.
  • On MaxOS, all seems to work good. Need to actually test a proper pip install .... to be sure.

Additionnal:
To reach this points, several distribution and architecture where skipped. More investigation will be needed later on. For now we apply the KISS methods.

@haesleinhuepf
Copy link
Member

I just saw this @StRigaud 🎉

image

@StRigaud
Copy link
Member Author

Not ready yet but yeah, it works 🚀
Still have a small issue with windows wheel but should be fix soon

@StRigaud
Copy link
Member Author

StRigaud commented Sep 2, 2022

pip install is set up now and should work fine though more test should be done at some point.
FYI new wheel will only be pushed when a new tag release is setup.

Next step is a conda recipe. I suppose we will have to pass by conda-forge.
@haesleinhuepf if you have any starter doc or procedure / example for me to look at that would be great.

@StRigaud
Copy link
Member Author

StRigaud commented Sep 6, 2022

Started to look in conda recipe:

For now it build and run test locally on my setup. Though not sure it is properly made and that all dependency are good, My experience tells me that it is not 😉

Main stuff to verify:

  • is OpenCL found at compile time for all OS?
  • is OpenCL found at runtime?
  • is recipe works with pocl or oclgrind?

If anybody have any insight on this I am happy to take!

EDIT: also maybe not PR until the API is back working and that the 0.6 version is ready enough for public test

@StRigaud
Copy link
Member Author

Conda recipe is ready. Waiting for conda-forge to review the recipe and create the feedstock if all is good

@StRigaud
Copy link
Member Author

conda recipe is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants