Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging v24.2 #31

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11743440459 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package packaging using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • noarch: python recipes should almost always follow the syntax in our documentation. For the host section of the recipe, you should almost always use python {{ python_min }} for the python entry. For the run section of the recipe, you should almost always use python >={{ python_min }} for the python entry. For the test.requires section of the recipe, you should almost always use python {{ python_min }} for the python entry. You may need to override the python_min variable in the conda_build_config.yaml/variants.yaml if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@ofek
Copy link

ofek commented Nov 10, 2024

Can this be merged?

@matthewfeickert
Copy link
Member

Can this be merged?

@conda-forge/packaging for context, this is required for hatchling v1.26.1 to be released (c.f. conda-forge/hatchling-feedstock#61).

@matthewfeickert
Copy link
Member

@conda-forge/core, sorry to ping you all, but could one of you merge this please as it is blocking a few other packages?

@synapticarbors synapticarbors merged commit fe339ec into conda-forge:main Nov 13, 2024
4 checks passed
@h-vetinari
Copy link
Member

@matthewfeickert, this feedstock is a bit "understaffed", would you mind adding yourself to maintainers here?

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 24.2_h4b0bd8 branch November 13, 2024 00:25
@matthewfeickert
Copy link
Member

this feedstock is a bit "understaffed", would you mind adding yourself to maintainers here?

@h-vetinari While I feel underqualified to be a maintainer on a core part of Python infrastructure, I guess the real responsibility lies with the PyPA team at https://github.com/pypa/packaging. I'll add myself in a follow up PR to address the noarch: python linter critiques, but as @ofek is actually part of the PyPA if he doesn't mind I'll add him as well.

@ofek
Copy link

ofek commented Nov 13, 2024

Sure that's fine, I will also post in Discord.

@henryiii
Copy link
Contributor

@matthewfeickert you don't have to be a member of the upstream package to help maintain a package on conda-forge.

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 16, 2024

you don't have to be a member of the upstream package to help maintain a package on conda-forge.

Oh I very much know that (given hep-packaging-coordination/packaging-hep-simulation-stack#1 among other things). packaging just feels "big" enough to be something that gave me pause being responsible for [at all].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants