-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Update feedstock recipe for modern noarch python #32
MNT: Update feedstock recipe for modern noarch python #32
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
The recipe should pass the linter, but the reason for the linter is complaining will be fixed by conda-forge/conda-smithy#2132. |
@conda-forge/packaging @conda-forge/core this is ready for review. c.f. #31 (comment) @ofek, please comment or 👍 if you accept being added as a feedstock maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I accept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for stepping up! @conda-forge/packaging, please let us know if you are OK with some additional support. Otherwise I will merge in ~1 week.
89bee62
to
cff9678
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11820030822. |
Gentle ping to @jakirkham and @nicoddemus. |
* Use 'python {{ python_min }}' syntax for the python requirements for noarch python recipes. - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python * Use a Jinja2 set statement for the python_min to allow all the build metadata to be contained in the recipe/meta.yaml and override the global python_min with packaging's python_min of 3.8. * Remove '--no-deps' as the build tool (e.g. conda-build, rattler-build) will specify all required 'pip install' options. * Use 'pypi.org'. * Add matthewfeickert and ofek as feedstock maintainers. * Bump build number. Co-authored-by: Henry Schreiner <[email protected]>
c515055
to
211b40c
Compare
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.16.14.10.20
@conda-forge/packaging @conda-forge/core now that we have approval, I've rebased and squashed and rerendered, and this is ready for merge. |
Thanks all! 🙏 |
python {{ python_min }}
syntax for the python requirements for noarch python recipes.set
statement for thepython_min
to allow all the build metadata to be contained in therecipe/meta.yaml
and override the globalpython_min
withpackaging
'spython_min
of3.8
.--no-deps
as the build tool (e.g.conda-build
,rattler-build
) will specify all requiredpip install
options.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)