Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Update feedstock recipe for modern noarch python #32

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 13, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 13, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package packaging using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@matthewfeickert
Copy link
Member Author

The recipe should pass the linter, but the reason for the linter is complaining will be fixed by conda-forge/conda-smithy#2132.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 13, 2024 01:19
@matthewfeickert
Copy link
Member Author

@conda-forge/packaging @conda-forge/core this is ready for review. c.f. #31 (comment)

@ofek, please comment or 👍 if you accept being added as a feedstock maintainer.

Copy link

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I accept.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stepping up! @conda-forge/packaging, please let us know if you are OK with some additional support. Otherwise I will merge in ~1 week.

recipe/meta.yaml Outdated Show resolved Hide resolved
@matthewfeickert matthewfeickert force-pushed the mnt/update-recipe branch 2 times, most recently from 89bee62 to cff9678 Compare November 13, 2024 15:04
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11820030822.

@matthewfeickert
Copy link
Member Author

Gentle ping to @jakirkham and @nicoddemus.

recipe/meta.yaml Outdated Show resolved Hide resolved
* Use 'python {{ python_min }}' syntax for the python requirements for noarch
  python recipes.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
* Use a Jinja2 set statement for the python_min to allow all the build
  metadata to be contained in the recipe/meta.yaml and override the global
  python_min with packaging's python_min of 3.8.
* Remove '--no-deps' as the build tool (e.g. conda-build, rattler-build)
  will specify all required 'pip install' options.
* Use 'pypi.org'.
* Add matthewfeickert and ofek as feedstock maintainers.
* Bump build number.

Co-authored-by: Henry Schreiner <[email protected]>
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert
Copy link
Member Author

@conda-forge/packaging @conda-forge/core now that we have approval, I've rebased and squashed and rerendered, and this is ready for merge.

@jakirkham jakirkham merged commit 9c58001 into conda-forge:main Nov 17, 2024
4 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@matthewfeickert matthewfeickert deleted the mnt/update-recipe branch November 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants