-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-compile linux-{aarch64,ppc64le} #87
Cross-compile linux-{aarch64,ppc64le} #87
Conversation
…nda-forge-pinning 2023.10.02.03.27.19
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
my previous attempts found that things were creating the wrong so names: |
Yeah, cross-compiling with python is a mass of ducktape, string and prayers... |
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.10.02.03.27.19
In any case, we should cross-compile linux, because travis is essentially completely red on ppc (not in the PRs, but all the merges to main have so far managed to produce 2(!) passing runs out of >20) |
…nda-forge-pinning 2023.10.02.03.27.19
I noticed that the Also, it's quite "dirty" to have an output named the same as the feedstock, that's a fragile setup (e.g. tests on the output get ignored)... WDYT? |
Co-authored-by: Mark Harfouche <[email protected]>
I'm not a fan of doing "special packaging work" when upstream doesn't make it clean to do so. Unfortunately, with the conda-machinery, it isn't too easy to pick and choose files. So I am inclined to just leave it as is. This is especially true when I am a passer-by on a recipe.
I'm not so sure about them getting ignored. But they do trigger special behavior. |
100% the case, it's a known issue.
Meh, it's just upstream being lazy and building everything in a bunch. I find it wasteful to rebuild the exact same library bits for X python versions when their content is exactly the same. |
If you want I can show you a draft on top of #88 (which we should rebase anyway once this PR is in). |
How does the It isn't so much about "getting it to work" but more about maintanance. Things like conda-forge/opencv-feedstock#365 (and the history of the recipe) make me scared to push this kind of "advanced packaging" onto others. |
Still getting the wrong extension on aarch:
I don't use that locally so much, but conceptually there's now a dependence on the global build step for (normally) all the outputs. So you have to do the global
OpenCV is exceptionally complex in how the various bits interact with each other, which is why I deprioritized this. In other cases it's really very straight forward. "These bits go into this output, these bits go in the other output" |
Most, it fails at the environment activation step. FWIW, the |
lets try in #88 |
This PR has been triggered in an effort to update python312.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6377365503, please use this URL for debugging.