Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #82

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6375666442, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 2, 2023

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Oct 2, 2023
@hmaarrfk hmaarrfk closed this Oct 2, 2023
@hmaarrfk hmaarrfk reopened this Oct 2, 2023
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@h-vetinari
Copy link
Member

Interestingly, osx-arm works, while linux cross-compilation doesn't. I'll try to rebase this (keeping aarch/ppc on travis) after #86

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Oct 2, 2023
@h-vetinari h-vetinari force-pushed the bot-pr_arm_osx_h935ca6 branch from 0d77ccd to 7f12a0f Compare October 2, 2023 07:15
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Oct 2, 2023
@h-vetinari
Copy link
Member

Travis is slooooow

@h-vetinari h-vetinari merged commit c01ba6f into conda-forge:main Oct 2, 2023
@h-vetinari h-vetinari mentioned this pull request Oct 2, 2023
5 tasks
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_h935ca6 branch October 2, 2023 08:04
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 2, 2023

FYI im not sure these builds are correct because functionality tests are skipped

@h-vetinari
Copy link
Member

I mean, you had already set the automerge label? 🤔

Not sure what you're referring to with functionality tests - you mean whether the build packages are actually importable? Yeah, I guess we don't know that for arm... Sorry. Would you mind giving the cross-compilation another shot?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 2, 2023

error: /Users/runner/miniforge3/conda-bld/openimageio_1696234087538/_build_env/bin/arm64-apple-darwin20.0.0-install_name_tool: for: /Users/runner/miniforge3/conda-bld/openimageio_1696234087538/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/OpenImageIO/OpenImageIO.cpython-38-darwin.so (for architecture arm64) option "-add_rpath /Users/runner/miniforge3/conda-bld/openimageio_1696234087538/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib" would duplicate path, file already has LC_RPATH for: /Users/runner/miniforge3/conda-bld/openimageio_1696234087538/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib

this seems to be consistent with other tools that also say "(for architecture arm64)" so i was somewhat being hopeful.

@h-vetinari
Copy link
Member

Sounds like the bot really wanted to try cross-compilation anyway: #87 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants