Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pynvml and nvidia-ml-py to be coinstalled for 12.* versions #24

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 18, 2024

Beginning with pynvml version 12, the package is a metapackage that depends on nvidia-ml-py for core functionality. So allow pynvml to be coinstalled with nvidia-ml-py.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

…onda-forge-pinning 2024.12.17.22.25.12

Re-render with maintainer updates.
Beginning with `pynvml` version `12`, the package is a metapackage that
depends on `nvidia-ml-py` for core functionality. So allow `pynvml` to
be coinstalled with `nvidia-ml-py`.
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12384922036. Examine the logs at this URL for more detail.

List requirements in `test` before listing tests to run.
…onda-forge-pinning 2024.12.17.22.25.12

Re-render to pull in `python_min` (needed for CFEP 25).
Rebuild to include dependency fixes.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham jakirkham marked this pull request as ready for review December 18, 2024 02:12
@jakirkham jakirkham requested a review from XuehaiPan as a code owner December 18, 2024 02:12
@XuehaiPan XuehaiPan merged commit 3417548 into conda-forge:main Dec 18, 2024
4 checks passed
@jakirkham jakirkham deleted the allow_pynvml branch December 18, 2024 05:39
@jakirkham
Copy link
Member Author

Thanks Xuehai! 🙏

@jakirkham
Copy link
Member Author

Adding a repodata patch to extend this to other nvidia-ml-py 12.* versions

xref: conda-forge/conda-forge-repodata-patches-feedstock#932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants