Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let nvidia-ml-py and pynvml 12.* coexist #932

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 18, 2024

Beginning with pynvml version 12.0.0, the pynvml library and package now depend on nvidia-ml-py for core functionality and merely provide a few extras on top of nvidia-ml-py. Given this, these two packages no longer clobber each other and instead nvidia-ml-py needs to be coinstallable with pynvml. Changes were made to both feedstocks to support this (as referenced below). This repodata patch extends this to nvidia-ml-py version 12.*.

References:


Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@jakirkham
Copy link
Member Author

cc @conda-forge/nvidia-ml-py @conda-forge/pynvml (for awareness)

@jakirkham
Copy link
Member Author

Here is the repodata patch diff from CI:

noarch::nvidia-ml-py-12.555.43-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.77-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.108-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.560.30-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.550.52-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.133-pyhd8ed1ab_0.conda
-    "pynvml ==9999999999"
+    "pynvml ~=12.0"

@hmaarrfk
Copy link
Contributor

what does ~=12.0 mean?

@jakirkham
Copy link
Member Author

jakirkham commented Dec 18, 2024

This is equivalent to pynvml >=12.0,<13.0a

More details in the package match specification docs

xref to similar discussion: conda-forge/pynvml-feedstock#18 (comment)

@jakirkham
Copy link
Member Author

@conda-forge-admin , please relint

(looks like the linter errored during installation)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

LGTM

@kkraus14 kkraus14 merged commit a58f77c into conda-forge:main Dec 19, 2024
3 checks passed
@jakirkham jakirkham deleted the fix_nvidia-ml-py_constraint_on_pynvml branch December 19, 2024 02:44
@jakirkham
Copy link
Member Author

Thanks Mark and Keith! 🙏

@jaimergp
Copy link
Member

I remember we were patching =~ out because it would break old conda versions. Also mamba v2 seems to have some trouble with it. Might be safer to use the equivalent >=x.y,x.*.

@jakirkham
Copy link
Member Author

How old of a version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants