-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let nvidia-ml-py
and pynvml
12.*
coexist
#932
Let nvidia-ml-py
and pynvml
12.*
coexist
#932
Conversation
cc @conda-forge/nvidia-ml-py @conda-forge/pynvml (for awareness) |
Here is the repodata patch diff from CI: noarch::nvidia-ml-py-12.555.43-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.77-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.108-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.560.30-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.550.52-pyhd8ed1ab_0.conda
noarch::nvidia-ml-py-12.535.133-pyhd8ed1ab_0.conda
- "pynvml ==9999999999"
+ "pynvml ~=12.0" |
what does ~=12.0 mean? |
This is equivalent to More details in the package match specification docs xref to similar discussion: conda-forge/pynvml-feedstock#18 (comment) |
@conda-forge-admin , please relint (looks like the linter errored during installation) |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
LGTM |
Thanks Mark and Keith! 🙏 |
I remember we were patching =~ out because it would break old conda versions. Also mamba v2 seems to have some trouble with it. Might be safer to use the equivalent |
How old of a version? |
Beginning with
pynvml
version12.0.0
, thepynvml
library and package now depend onnvidia-ml-py
for core functionality and merely provide a few extras on top ofnvidia-ml-py
. Given this, these two packages no longer clobber each other and insteadnvidia-ml-py
needs to be coinstallable withpynvml
. Changes were made to both feedstocks to support this (as referenced below). This repodata patch extends this tonvidia-ml-py
version12.*
.References:
pynvml
module and convert to a "meta package" gpuopenanalytics/pynvml#57pynvml
andnvidia-ml-py
to be coinstalled for12.*
versions nvidia-ml-py-feedstock#24Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.