Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlflow v1.5.0 #24

Merged
merged 4 commits into from
Dec 28, 2019
Merged

mlflow v1.5.0 #24

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcd8da7
updated v1.5.0
Dec 24, 2019
8d3bcb8
MNT: Re-rendered with conda-build 3.18.11, conda-smithy 3.6.5, and co…
Dec 24, 2019
67f8e14
Update meta.yaml
smurching Dec 25, 2019
abbb9f2
Update meta.yaml
smurching Dec 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{% set name = "mlflow" %}
{% set version = "1.4.0" %}
{% set version = "1.5.0" %}

package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"
sha256: 9116d82be380c32fa465049d14b217c4c200ad11614f4c6674e6b524b2935206
sha256: c5a9bda701498d44a3a5b1df646ab08691b482fca326c69e0b91c594b0788487

build:
number: 0
Expand Down Expand Up @@ -38,6 +38,7 @@ requirements:
- numpy
- pandas
- pip
- prometheus-flask-exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this new dependency with MLflow 1.5.0 - it's only available on conda via an out-of-date / seemingly unmaintained channel (https://anaconda.org/giperball/prometheus-flask-exporter). As described in conda/conda-build#548, it's not currently possible to include PyPI-only dependencies in conda recipes, & there doesn't seem to have been progress on allowing recipes to depend on packages in custom conda channels (see conda/conda#1504), so will remove the prometheus-flask-exporter dependency for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies are straight-forward to add: conda-forge/staged-recipes#10505 No need to remove them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks @xhochy! Now that it's on conda-forge, would be happy to approve a PR adding the prometheus-flask-exporter dependency to the MLflow recipe

- protobuf >=3.6.0
- python-dateutil
- pyyaml
Expand Down