-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlflow v1.5.0 #24
mlflow v1.5.0 #24
Conversation
…nda-forge-pinning 2019.12.18
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/meta.yaml
Outdated
@@ -38,6 +38,7 @@ requirements: | |||
- numpy | |||
- pandas | |||
- pip | |||
- prometheus-flask-exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added this new dependency with MLflow 1.5.0 - it's only available on conda via an out-of-date / seemingly unmaintained channel (https://anaconda.org/giperball/prometheus-flask-exporter). As described in conda/conda-build#548, it's not currently possible to include PyPI-only dependencies in conda recipes, & there doesn't seem to have been progress on allowing recipes to depend on packages in custom conda channels (see conda/conda#1504), so will remove the prometheus-flask-exporter
dependency for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies are straight-forward to add: conda-forge/staged-recipes#10505 No need to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks @xhochy! Now that it's on conda-forge, would be happy to approve a PR adding the prometheus-flask-exporter
dependency to the MLflow recipe
It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:
Checklist before merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one.This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/13087, please use this URL for debugging