Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of pip with wrong python constraints #929

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix version of pip with wrong python constraints #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions recipe/patch_yaml/pip.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,15 @@ then:
- add_depends:
- setuptools
- wheel
---
# See https://github.com/conda-forge/pip-feedstock/issues/132
# There is a build of pip that does not have wheel and setuptools
# dependency, and does not have the correct constraint on the python version
Comment on lines +45 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not add wheel and setuptools then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct for pip not to have wheel and setuptools if installed with python>=3.13, see conda-forge/pip-feedstock#126 . The problem is that this build was meant to be installed only for python>=3.13, but this specific build did not have this constraint. This repodata patch remove the incorrect run constraint python >=3.9 and adds the correct one python >=3.13.0a0 (see also the output of show_diff script).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, you're right, I had gotten it mixed up how things should have been vs. how they were vs. how to undo the damage. 😅

if:
name: pip
version_in: ["24.3.1"]
build: pyh145f28c_1
then:
- replace_depends:
old: python >=3.9
new: python >=3.13.0a0
Loading