Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of pip with wrong python constraints #929

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Dec 17, 2024

Fix part of conda-forge/pip-feedstock#132 .

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@traversaro traversaro requested a review from a team as a code owner December 17, 2024 08:59
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

diff:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::pip-24.3.1-pyh145f28c_1.conda
-    "python >=3.9"
+    "python >=3.13.0a0"
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64

Comment on lines +45 to +48
---
# See https://github.com/conda-forge/pip-feedstock/issues/132
# There is a build of pip that does not have wheel and setuptools
# dependency, and does not have the correct constraint on the python version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not add wheel and setuptools then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct for pip not to have wheel and setuptools if installed with python>=3.13, see conda-forge/pip-feedstock#126 . The problem is that this build was meant to be installed only for python>=3.13, but this specific build did not have this constraint. This repodata patch remove the incorrect run constraint python >=3.9 and adds the correct one python >=3.13.0a0 (see also the output of show_diff script).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, you're right, I had gotten it mixed up how things should have been vs. how they were vs. how to undo the damage. 😅

@h-vetinari h-vetinari merged commit b9b6d02 into conda-forge:main Dec 17, 2024
3 checks passed
@traversaro traversaro deleted the patch-9 branch December 17, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants