-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version of pip with wrong python constraints #929
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
diff:
|
--- | ||
# See https://github.com/conda-forge/pip-feedstock/issues/132 | ||
# There is a build of pip that does not have wheel and setuptools | ||
# dependency, and does not have the correct constraint on the python version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not add wheel and setuptools then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct for pip not to have wheel and setuptools if installed with python>=3.13
, see conda-forge/pip-feedstock#126 . The problem is that this build was meant to be installed only for python>=3.13
, but this specific build did not have this constraint. This repodata patch remove the incorrect run constraint python >=3.9
and adds the correct one python >=3.13.0a0
(see also the output of show_diff
script).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, you're right, I had gotten it mixed up how things should have been vs. how they were vs. how to undo the damage. 😅
Fix part of conda-forge/pip-feedstock#132 .
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.