Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix protobuf constraints for old streamlit versions #893

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ytausch
Copy link

@ytausch ytausch commented Oct 31, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

This is a best-effort PR to avoid solving streamlit with newer protobuf versions, based on version constraints used for newer packages.

The current diff generated with show_diff is empty. Is there something I am doing wrong here?

Cc @pavelzw

@ytausch ytausch requested a review from a team as a code owner October 31, 2024 17:28
@ytausch ytausch marked this pull request as draft October 31, 2024 17:28
@ytausch ytausch force-pushed the streamlit-fix-protobuf branch from 3c1b8fc to c5e3139 Compare October 31, 2024 17:29
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ytausch ytausch force-pushed the streamlit-fix-protobuf branch from c5e3139 to 96636e6 Compare October 31, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants