Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer lief again #83

Closed
wants to merge 4 commits into from
Closed

Use newer lief again #83

wants to merge 4 commits into from

Conversation

h-vetinari
Copy link
Member

No description provided.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Stuck (again) on conda-forge/boa-feedstock#75

conda-forge.yml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

We might need updated lower bounds for conda-build & conda so we update conda 23.3 (as bundled in Miniforge right now) to at least 23.7.4, which will also bring a more recent conda-libmamba-solver.

We might also force this via remote_ci_setup?

conda-forge.yml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

We might need mamba>=1.5.2 there too, I think.

@h-vetinari
Copy link
Member Author

Alright, that's a combination that works! 🥳

@isuruf
Copy link
Member

isuruf commented Oct 25, 2023

@conda-forge-admin, rerender

Copy link
Member Author

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, even though it's not specified in the conda install step, something seems to try to pull in an exact mamba version that's too old:

├─ mamba 1.4.2  is installable with the potential options
         ^^^^^
         why pinned?

conda-forge.yml Outdated
Comment on lines 9 to 11
conda_build_tool: "conda-build"
conda_install_tool: "conda"
conda_solver: "libmamba"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these lines with conda-forge-ci-setup=4?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, ci-setup is going to nudge the solvers to obtain the "latest everything" but the conda-smithy config is still needed here because the default is still "mamba + mambabuild". In the (not so long!) future, when conda-build + conda-libmamba-solver is default we can omit this section.

@h-vetinari
Copy link
Member Author

something seems to try to pull in an exact mamba version that's too old:

Should be solved by conda-forge/conda-forge-ci-setup-feedstock#290; I'll restart

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 25, 2023

Nope, still getting lost with looking for 1.4.2, possibly because that's what's there after the mambaforge install.

@jaimergp
Copy link
Member

That might be a manifestation of an conda-libmamba-solver bug. The miniforge we are using bundles 23.3 and that one was a bit stubborn about the history if things were not explicitly mentioned in the CLI. Maybe using conda_install_tool=mamba helps? I'll add a comment.

conda-forge.yml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

@conda-forge-admin, rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants