Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to conda-build with libmamba solver #1786

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 26, 2023

Checklist

  • Added a news entry

@isuruf isuruf requested a review from a team as a code owner October 26, 2023 19:38
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well go back to only using conda to install packages as well since the advantages of mamba are less now?

@isuruf
Copy link
Member Author

isuruf commented Oct 26, 2023

There are some issues with the old conda+conda-libmamba-solver installed in Miniforge by default that refuses to update conda-libmamba-solver. See conda-forge/compiler-rt-feedstock#83 (comment)
We'll keep mamba for now and then once we have released a new conda-smithy we can update miniforge. (We can't update the mamba version in miniforge since boa is not compatible with that)

@jakirkham
Copy link
Member

Can we release a new Miniforge to address that issue?

@isuruf
Copy link
Member Author

isuruf commented Oct 26, 2023

Can we release a new Miniforge to address that issue?

No, as I said

We can't update the mamba version in miniforge since boa is not compatible with that

@jakirkham
Copy link
Member

Right thought we could drop boa based on our discussion in the last core meeting. Is that not the case?

@isuruf
Copy link
Member Author

isuruf commented Oct 26, 2023

Yes, we can, but we need this PR first to update the feedstocks.

@jakirkham
Copy link
Member

Ok cool. Thanks for clarifying! 🙏

Comment on lines 1859 to 1861
"conda_build_tool": "conda-build+conda-libmamba-solver",
"conda_install_tool": "mamba",
"conda_install_tool_deps": "mamba",
"conda_solver": None,
"conda_solver": "libmamba",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant right now. We can get by with either just conda_build_tool: conda-build + conda_solver: libmamba or conda_build_tool: conda-build+conda-libmamba-solver + conda_solver: None.

It's also ok to leave it like it's right now (doesn't hurt), but in case someone was wondering whether the two are needed: the answer is no.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the first is better from a readability standpoint?

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @isuruf !

@isuruf isuruf merged commit fb33967 into conda-forge:main Oct 30, 2023
1 check passed
@isuruf isuruf deleted the libmamba branch October 30, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants