-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to conda-build with libmamba solver #1786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well go back to only using conda to install packages as well since the advantages of mamba are less now?
There are some issues with the old conda+conda-libmamba-solver installed in Miniforge by default that refuses to update conda-libmamba-solver. See conda-forge/compiler-rt-feedstock#83 (comment) |
Can we release a new Miniforge to address that issue? |
No, as I said
|
Right thought we could drop |
Yes, we can, but we need this PR first to update the feedstocks. |
Ok cool. Thanks for clarifying! 🙏 |
conda_smithy/configure_feedstock.py
Outdated
"conda_build_tool": "conda-build+conda-libmamba-solver", | ||
"conda_install_tool": "mamba", | ||
"conda_install_tool_deps": "mamba", | ||
"conda_solver": None, | ||
"conda_solver": "libmamba", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant right now. We can get by with either just conda_build_tool: conda-build
+ conda_solver: libmamba
or conda_build_tool: conda-build+conda-libmamba-solver
+ conda_solver: None
.
It's also ok to leave it like it's right now (doesn't hurt), but in case someone was wondering whether the two are needed: the answer is no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the first is better from a readability standpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @isuruf !
Checklist
news
entry