Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFEP-25: Globally Pinned Minimum Python Version for noarch: python Packages #56

Merged
merged 7 commits into from
Nov 2, 2024
Merged

CFEP-25: Globally Pinned Minimum Python Version for noarch: python Packages #56

merged 7 commits into from
Nov 2, 2024

Conversation

beckermr
Copy link
Member

This PR adds a CFEP for globally pinned minimum python versions for noarch: python packages. It follows the discussion and consensus reached in github issue conda-forge/conda-forge.github.io#2210.

@beckermr beckermr mentioned this pull request Oct 12, 2024
Closed
@beckermr beckermr marked this pull request as ready for review October 12, 2024 11:22
@beckermr beckermr requested a review from a team as a code owner October 12, 2024 11:22
jaimergp
jaimergp reviewed Oct 15, 2024
View reviewed changes
cfep-25.md Outdated Show resolved Hide resolved
@beckermr @jaimergp
Update cfep-25.md
42f138f 
Co-authored-by: jaimergp <[email protected]>
@beckermr
Copy link
Member Author

@conda-forge/core

This PR falls under the CFEP Vote policy, please vote and/or comment on this PR. This PR needs 60% of core to vote yea to pass.

To vote please leave a PR review according to

  • Approve (yea)
  • Request Changes (nay)
  • Comment w/ "abstain" in it (abstain)

If you would like changes to the current language please leave a comment or push to this branch.

This vote will end on 2024-10-31.

beckermr
beckermr commented Oct 15, 2024
View reviewed changes
Copy link
Member Author

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote yae and am leaving a comment since I cannot approve my own PR.

h-vetinari
h-vetinari approved these changes Oct 16, 2024
View reviewed changes
cfep-25.md Show resolved Hide resolved
@beckermr
Copy link
Member Author

@conda-forge/core please vote!

@beckermr
Copy link
Member Author

@conda-forge/core please vote!

@beckermr
Copy link
Member Author

this vote ends tomorrow Oct 31 BTW

jakirkham
jakirkham approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt! 🙏

Approve

Think this is great!

Tried to expand on and draw attention to important points in this proposal with some suggestions below. Think they would help readers less plugged into these conversations understand our thinking and motivation for this change. Plus how it will help them

cfep-25.md Outdated Show resolved Hide resolved
cfep-25.md Outdated Show resolved Hide resolved
cfep-25.md Outdated Show resolved Hide resolved
beckermr and others added 3 commits October 31, 2024 08:07
@beckermr @jakirkham
Update cfep-25.md
6e311b5 
Co-authored-by: jakirkham <[email protected]>
@beckermr @jakirkham
Update cfep-25.md
467eac6 
Co-authored-by: jakirkham <[email protected]>
@beckermr @jakirkham
Update cfep-25.md
22cfe4c 
Co-authored-by: jakirkham <[email protected]>
@beckermr
Copy link
Member Author

beckermr commented Nov 2, 2024

This vote has passed. We have 21 yes, 0 no and 0 abstain. It exceeds the 60% quorum requirement of 60% (17 out of 28). Yay!

@beckermr beckermr merged commit fa401e4 into main Nov 2, 2024
@beckermr beckermr deleted the cfep-25 branch November 2, 2024 10:20
@h-vetinari h-vetinari mentioned this pull request Nov 4, 2024
Merged
@h-vetinari h-vetinari mentioned this pull request Nov 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@minrk minrk minrk approved these changes

@msarahan msarahan msarahan approved these changes

@bgruening bgruening bgruening approved these changes

@viniciusdc viniciusdc viniciusdc approved these changes

@synapticarbors synapticarbors synapticarbors approved these changes

@ocefpaf ocefpaf ocefpaf approved these changes

@wolfv wolfv wolfv approved these changes

@chrisburr chrisburr chrisburr approved these changes

@jaimergp jaimergp jaimergp approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@jezdez jezdez jezdez approved these changes

@xhochy xhochy xhochy approved these changes

@chenghlee chenghlee chenghlee approved these changes

@dopplershift dopplershift dopplershift approved these changes

@mariusvniekerk mariusvniekerk mariusvniekerk approved these changes

@h-vetinari h-vetinari h-vetinari approved these changes

@marcelotrevisani marcelotrevisani marcelotrevisani approved these changes

@ericdill ericdill ericdill approved these changes

@mwcraig mwcraig mwcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.