Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python_min variable per CFEP-25 #6646

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Nov 4, 2024

This PR adds the python_min variable per CFEP-25.

Fixes #6645

@beckermr beckermr changed the title MNT: rerender feat: add python_min variable per CFEP-25 Nov 4, 2024
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits November 4, 2024 11:08
@beckermr beckermr marked this pull request as ready for review November 4, 2024 11:14
@beckermr beckermr requested a review from a team as a code owner November 4, 2024 11:14
@beckermr
Copy link
Member

beckermr commented Nov 4, 2024

@conda-forge/core this one is ready for review!

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Just reread conda-forge/cfep#56 and it doesn't go into details about the roll-out strategy. I guess we'll have to modify the linter and probably set up a piggyback migrator to rewrite noarch outputs?

@beckermr
Copy link
Member

beckermr commented Nov 4, 2024

Yes that's correct! I put a list of todo items here and am slowly working through them.

@beckermr beckermr merged commit 013ccb2 into conda-forge:main Nov 4, 2024
3 checks passed
@jakirkham
Copy link
Member

Thanks Matt! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin rerender
4 participants