Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antigrain: add library #16865
antigrain: add library #16865
Changes from 10 commits
3e6541c
60e0b11
84796e8
090804a
0570aa3
d218751
6bdf926
97b4cb9
135ee5e
292d1a5
bf94186
53c000a
c9b0cb7
134e59f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this is a fork of the main repo which is still very active https://github.com/ghaerr/agg-2.6
We generally do not accept these, is there a reason you did not use the original or contribute to it? I saw they made improvements to their CMake just 2 days ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, my pr may look strange and I understand your position. Let me explain my position. Firstly, I don't see any commits since Jul 21, 2022. Secondly, it contains only 19 commits from May 6, 2019. Others commits do not relay to current repo and current owner. Thirdly, 2.6.0 was released in 2018 and no releases were published in current repo. You said it active, maybe. I'm not sure how to classify this is active and this is not. You can look at pull requests https://github.com/ghaerr/agg-2.6/pulls. There are 2 prs, and they related to cmake improvements, they were not reviewed for years. If you are strongly against using fork, I will create another third pull request. But I'd be willing to bet that no one will review it or accept for years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In such a case I would recommend using our
author-
prefix so that it's more clearly evident that this is a specific variant of a project :)this way people can benifit from the project while not getting mixed up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc what is
author-
prefix? I could not find any docs about thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-is-the-policy-on-recipe-name-collisions
🤔 I need to write better docs for that....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc thank you, I applied your suggestion but looks like cla bot is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have this option? can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you are right. I still leave it there because maybe someone will test shared library, and we'll enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jihadist please, sign the CLA again. It has been updated. Sorry for the inconvenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries thank you, I signed