-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antigrain: add library #16865
antigrain: add library #16865
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
add copying
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/agg/all/conanfile.py
Outdated
description = 'AGG Anti-Grain Geometry Library' | ||
topics = ('graphics') | ||
url = "https://github.com/conan-io/conan-center-index" | ||
homepage = 'https://github.com/aggeom' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this is a fork of the main repo which is still very active https://github.com/ghaerr/agg-2.6
We generally do not accept these, is there a reason you did not use the original or contribute to it? I saw they made improvements to their CMake just 2 days ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, my pr may look strange and I understand your position. Let me explain my position. Firstly, I don't see any commits since Jul 21, 2022. Secondly, it contains only 19 commits from May 6, 2019. Others commits do not relay to current repo and current owner. Thirdly, 2.6.0 was released in 2018 and no releases were published in current repo. You said it active, maybe. I'm not sure how to classify this is active and this is not. You can look at pull requests https://github.com/ghaerr/agg-2.6/pulls. There are 2 prs, and they related to cmake improvements, they were not reviewed for years. If you are strongly against using fork, I will create another third pull request. But I'd be willing to bet that no one will review it or accept for years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In such a case I would recommend using our author-
prefix so that it's more clearly evident that this is a specific variant of a project :)
this way people can benifit from the project while not getting mixed up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc what is author-
prefix? I could not find any docs about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I need to write better docs for that....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc thank you, I applied your suggestion but looks like cla bot is broken.
recipes/agg/all/conanfile.py
Outdated
if self.options.shared: | ||
raise ConanInvalidConfiguration("Invalid configuration") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have this option? can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you are right. I still leave it there because maybe someone will test shared library, and we'll enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jihadist please, sign the CLA again. It has been updated. Sorry for the inconvenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries thank you, I signed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 18 (
Conan v2 pipeline ✔️
All green in build 17 (
|
* add agg * linter fixes * linter fixes * fix requires * Update conanfile.py add copying * fix copying * fix debug suffix * remove suffix * fix fpic * fix fpic for v2 * Apply suggestions from code review Co-authored-by: Chris Mc <[email protected]> * misprint * rename package with author prefix and move to tag 2.6.1 * fix package name --------- Co-authored-by: Chris Mc <[email protected]>
* add agg * linter fixes * linter fixes * fix requires * Update conanfile.py add copying * fix copying * fix debug suffix * remove suffix * fix fpic * fix fpic for v2 * Apply suggestions from code review Co-authored-by: Chris Mc <[email protected]> * misprint * rename package with author prefix and move to tag 2.6.1 * fix package name --------- Co-authored-by: Chris Mc <[email protected]>
* add agg * linter fixes * linter fixes * fix requires * Update conanfile.py add copying * fix copying * fix debug suffix * remove suffix * fix fpic * fix fpic for v2 * Apply suggestions from code review Co-authored-by: Chris Mc <[email protected]> * misprint * rename package with author prefix and move to tag 2.6.1 * fix package name --------- Co-authored-by: Chris Mc <[email protected]>
Specify library name and version: agg/2.6.0
I have been submitting my own fork because the library has not been supported for years, and here is a final version. If you have questions please look at ghaerr/agg-2.6#1 and then ghaerr/agg-2.6#6
Package is linked to commit due to any changes maybe requested. If pull request is ok, I'll create a tag for commit and relink package.
Shared option was disabled because I cannot find that origin package makefiles support shared build.