-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit environment.yml + Add unit-tests for particle_metadata.ipynb #75
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There is a problem in this PR, as the unit-tests of ioSPI are taking over an hour, due to the installation of conda dependencies. (see screenshot below) We should investigate the source of the problem, and add a fix so that the unit-tests do not take as long, because unit-tests that take over an hour will prevent many contributors from adding code to the library, as it will be very frustrating. The conda dependencies are in the environment.yml file at the root of the repository. The long unit-tests have first been observed in PR #75 , but not in other recent PRs, thus it should come from additions made in this PR: the install of jupyter or the install of osfclient maybe? |
Installing jupyter (via pip) in geomstats' workflows does not take as long: jupyter is in doc requirements: |
FYI, I've encountered the same issue in PR #83 exactly after the commit that added |
@artajmir3 thanks for the insight! Yes, we are not sure why this is taking so long. Let us know if you find out how to solve this jupyter issue? We need to solve it before we can merge this PR and your PR :) |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 5 5
Lines 223 223
=======================================
Hits 220 220
Misses 3 3 Continue to review full report at Codecov.
|
The same path problem occurred when installing jupyter with pip. Also, subprocess.check_call() didn't work. So I changed it to subprocess.run() and it works now. I think the DeppSource error can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bongjinkoo !!
This PR:
environment.yml
by removing unnecessary github import of simSPItest_notebooks.py
file to test jupyter notebooksparticle_metadata.ipynb
Note that
download_and_upload_with_osf.ipynb
is not tested as the jupyter notebook is currently running for too long.